[VRM0][Importer]IVrm0XSpringBoneRuntime #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
changed the title
ousttrue
changed the title
ousttrue
commented
Sep 19, 2024
| var instance = await VrmUtility.LoadBytesAsync(path, bytes, GetIAwaitCaller(m_useAsync.isOn), | ||
| materialCallback, metaCallback, | ||
| loadAnimation: m_loadAnimation.isOn, | ||
| springboneRuntime: m_useFastSpringBone.isOn ? new Vrm0XFastSpringboneRuntime() : new Vrm0XSpringBoneDefaultRuntime() |
Santarh
approved these changes
Sep 20, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importer で SpringBone の runtime 実行システムをスイッチするインタフェース。
TODO
Job かつ Singleton でないバージョン。各 VRMSpringBone の Update ではなく Root から Update するタイプ。関連して root に Vrm0xSpringBoneRuntime を新設予定。
#2420
で作った
UseRuntimeScalingSupportの置き場所もこっちに移動予定。TODO
VRM-1.0 は FastSpring ボーン１種類しかないので、試しに
Job かつ Singleton じゃないバージョンを作ってスイッチできるようにする。