feat(guide/computed): add previous to computed #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NataliaTepluhina
requested changes
Sep 26, 2024
src/guide/essentials/computed.md
Outdated
| // When count is >=4, the last value that fulfilled our condition will be returned | ||
| // instead until count is less or equal to 3 | ||
| alwaysSmall(previous) { | ||
| if (this.count >= 3) { |
There was a problem hiding this comment.
question: should this be <=3 according to the explanation above?
src/guide/essentials/computed.md
Outdated
| // When count is >=4, the last value that fulfilled our condition will be returned | ||
| // instead until count is less or equal to 3 | ||
| const alwaysSmall = computed((previous) => { | ||
| if (count.value >= 3) { |
|
Good catch @NataliaTepluhina! Changed the logic a few times while working on this because I wasn't convinced in the examples that I was providing and completely missed this! I also added the closing |
|
Thank you @ferferga! I've updated also the examples for writable computeds and I think we're good to go now |
NataliaTepluhina
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was shipped silently in Vue 3.4. See PR