Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cancel creating new file #281

Merged
merged 4 commits into from
Sep 7, 2024

Conversation

btea
Copy link
Contributor

@btea btea commented Sep 7, 2024

When the file name is empty, it looks weird after the input box loses focus.

image

Copy link

vercel bot commented Sep 7, 2024

@btea is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Sep 7, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/vuejs/repl/@vue/repl@281

commit: c88c806

@btea btea changed the title fix: exit add state when file is not supported fix: exit add state when file name is empty Sep 7, 2024
Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 1:56pm

@sxzz
Copy link
Member

sxzz commented Sep 7, 2024

How can make file name empty?

@btea
Copy link
Contributor Author

btea commented Sep 7, 2024

For example, if you want to add a new file by adding the add icon, but then want to delete it, you can directly delete the file name and press the enter key. (Currently, in this case, you can only create a file first and then delete it.)

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweak the order

@sxzz sxzz merged commit 7467f38 into vuejs:main Sep 7, 2024
1 of 2 checks passed
@sxzz sxzz changed the title fix: exit add state when file name is empty fix: cancel creating new file Sep 7, 2024
@btea btea deleted the fix/file-name-empty-should-exit-add branch September 7, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants