This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17.
ESLint and Prettier have been added to
vsf-capybara
. ESLint is configured to useeslint
,vue
andprettier
recommended rules. Prettier is configured with own defaults (out of the box) but empty.prettierrc
has been included in this repo to provide place for custom rules, if needed in the future.I fixed all errors and warnings in
capybara
akadefault
theme basing on current ESLint and Prettier configuration:eslint --ext .js,.vue ./ --fix
:v-html
have been replaced withv-text
v-for
used together withv-if
have been replaced with equivalent computed propertiespages/Category.vue
by disablingrequire-atomic-updates
rule due to pending fix in ESLint require-atomic-updates false positive eslint/eslint#11899package.json
for currentcapybara
theme to match its real dependencies used in source code - it should be updated as soon asstorefront-ui
components are integrated and legacy code becomes unusedThe
lint
script has been added topackage.json
anddev
script now points to main repo (yourvue-storefront
) since there is no sense to just build theme without mainvue-storefront
project.Now
vsf-capybara
is error and warning free and it just waits for actual start of development 😎I have a lot of problems and conflicts with integration ESLint 6.x and it seems that it is quite common: microsoft/vscode-eslint#696 (it is in vscode repo but it looks like this is quite "global" issue). Finally, I had to downgrade to the latest 5.x version which works perfectly.