Skip to content

Commit

Permalink
fix(VDialog): fix dialog error when clicking on overlay (#8246)
Browse files Browse the repository at this point in the history
dependent mixin was typing this.overlay as an HTMLElement when it was
in fact a VOverlay instance.

closes #8240
  • Loading branch information
nekosaur authored and johnleider committed Aug 1, 2019
1 parent 7932d7a commit 400542f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/vuetify/src/mixins/dependent/index.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import Vue from 'vue'

import mixins from '../../util/mixins'
import { VOverlay } from '../../components/VOverlay'

interface options extends Vue {
$el: HTMLElement
$refs: {
content: HTMLElement
}
overlay?: HTMLElement
overlay?: InstanceType<typeof VOverlay>
}

interface DependentInstance extends Vue {
Expand Down Expand Up @@ -71,7 +72,7 @@ export default mixins<options>().extend({
getClickableDependentElements (): HTMLElement[] {
const result = [this.$el]
if (this.$refs.content) result.push(this.$refs.content)
if (this.overlay) result.push(this.overlay)
if (this.overlay) result.push(this.overlay.$el as HTMLElement)
result.push(...this.getOpenDependentElements())

return result
Expand Down

0 comments on commit 400542f

Please sign in to comment.