Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Click on persistent dialog overlay generates error #8240

Closed
christher-lenander opened this issue Aug 1, 2019 · 0 comments · Fixed by #8246
Closed

[Bug Report] Click on persistent dialog overlay generates error #8240

christher-lenander opened this issue Aug 1, 2019 · 0 comments · Fixed by #8246
Assignees
@nekosaur
Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected
Milestone
v2.0.x

Comments

@christher-lenander
Copy link

Environment

Vuetify Version: 2.0.3
Vue Version: 2.6.10
Browsers: Chrome 75.0.3770.142
OS: Windows 10

Steps to reproduce

Add a drawer with an overlay and a persistant dialog and open it and click on overlay. It will generate an error in chrome console.

Expected Behavior

No error

Actual Behavior

Generates error

Reproduction Link

https://codepen.io/anon/pen/WVOaKj
@ghost ghost added the S: triage label Aug 1, 2019
@nekosaur nekosaur self-assigned this Aug 1, 2019
@nekosaur nekosaur added C: VDialog VDialog T: bug Functionality that does not work as intended/expected and removed S: triage labels Aug 1, 2019
nekosaur added a commit that referenced this issue Aug 1, 2019
@nekosaur
fix(VDialog): fix dialog error when clicking on overlay
6c3969c 
dependent mixin was typing this.overlay as an HTMLElement when it was
in fact a VOverlay instance.

closes #8240
@nekosaur nekosaur mentioned this issue Aug 1, 2019
Merged
9 tasks
johnleider pushed a commit that referenced this issue Aug 1, 2019
@nekosaur @johnleider
fix(VDialog): fix dialog error when clicking on overlay (#8246)
400542f 
dependent mixin was typing this.overlay as an HTMLElement when it was
in fact a VOverlay instance.

closes #8240
@johnleider johnleider added this to the v2.0.x milestone Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nekosaur nekosaur

Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.0.x
Development

Successfully merging a pull request may close this issue.

[Bug] fix(VDialog): fix dialog error when clicking on overlay vuetifyjs/vuetify
3 participants
@nekosaur @johnleider @christher-lenander