Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.4.10] Changing select-strategy in DataTable does not update the select all button #19069

Closed
oowais opened this issue Jan 18, 2024 · 2 comments · Fixed by #19762, Enterprise-CMCS/cmcs-eregulations#1315 or LLotme/esp-idf#19 · May be fixed by LLotme/esp-idf#5 or LLotme/esp-idf#12
Assignees
Labels
C: VDataTable VDatatable T: bug Functionality that does not work as intended/expected
Milestone

Comments

@oowais
Copy link

oowais commented Jan 18, 2024

Environment

Vuetify Version: 3.4.10
Vue Version: 3.4.14
Browsers: Chrome 120.0.0.0
OS: Linux x86_64

Steps to reproduce

  • Make sure that the initial value of select-strategy is 'single'
  • Change the value using a button or some other means to 'page' or 'all'

Expected Behavior

The select all button doesn't render on changing the select-strategy from 'single' to 'page'/'all'

Actual Behavior

The select all button should render

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

Also worth noting, If the initial value is not 'single', and then later changed to single programmatically, the select all button doesn't get removed, it stays, however it is unclickable.

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VDataTable VDatatable labels Jan 18, 2024
@websitevirtuoso
Copy link
Contributor

This has been fixed in this PR
#18908

But still in review

@oowais
Copy link
Author

oowais commented May 2, 2024

This has been fixed in this PR #18908

But still in review

This PR is merged but unfortunately doesn't fix the issue.

@johnleider johnleider self-assigned this May 7, 2024
@johnleider johnleider added this to the v3.6.x milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment