Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Using coloured badge in <v-bottom-nav> #2685

Closed
Nc32 opened this issue Dec 1, 2017 · 4 comments
Closed

[Feature Request] Using coloured badge in <v-bottom-nav> #2685

Nc32 opened this issue Dec 1, 2017 · 4 comments
Assignees
Labels
T: feature A new feature
Milestone

Comments

@Nc32
Copy link

Nc32 commented Dec 1, 2017

New Functionality

Trying to use coloured badge in v-bottom-nav.
But it shows like this: https://codepen.io/nc32/pen/NwevRy

Improvements

https://codepen.io/nc32/pen/pdqaQy
this is just an example, not a solution.AFAIK It doesn't work in shift mode

Bugs or Edge Cases it Helps Avoid

nothing.

@johnleider johnleider self-assigned this Dec 11, 2017
@johnleider johnleider added the T: feature A new feature label Dec 11, 2017
@johnleider johnleider added this to the v1.2.x milestone Dec 11, 2017
@richardtallent
Copy link

+1 on this, I was just about to file a report for it. It's due to the selectors used for the greyscale filter and the 0.5 opacity. I was able to work around it for now with similar CSS:

.badge__badge {
	width: 1.1em;
	height: 1.1em;
	margin-top: 0.2em;
}
.bottom-nav .btn:not(.btn--active) {
	filter: none;
	opacity: 1;
}
.bottom-nav .btn:not(.btn--active) .btn__content svg,
.bottom-nav .btn:not(.btn--active) .btn__content > span:not(.badge) {
	filter: grayscale(100%);
	opacity: 0.4;
}

This also tweaks the metrics, since the badges by default don't seem appropriately proportional to the icon. There's a bit in there about SVG because I'm using FA 5 Pro icons rather than Material in my nav.

@seifip
Copy link

seifip commented Apr 29, 2018

Any update on this?

@johnleider
Copy link
Member

It has a milestone on it...

@johnleider
Copy link
Member

I'm going to push this to v1.4 (possibly v1.3) to coincide with the toolbar refactor as it will use it as a baseline in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: feature A new feature
Projects
None yet
Development

No branches or pull requests

4 participants