Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Spacing should have "start" and "end" directions #4660

Closed
tamirvs opened this issue Jul 18, 2018 · 2 comments
Closed

[Feature Request] Spacing should have "start" and "end" directions #4660

tamirvs opened this issue Jul 18, 2018 · 2 comments
Assignees
@jacekkarczmarczyk
Labels
framework Issues and Feature Requests that have needs framework-wide. T: feature A new feature
Milestone
v2.0.0

Comments

@tamirvs
Copy link

tamirvs commented Jul 18, 2018

What problem does this feature solve?

Having start and end directions for spacing could help a lot with designs that support both RTL and LTR.

What is your proposed solution?

s - applies the spacing for *-left in LTR and *-right in RTL.
e - applies the spacing for *-right in RTL and *-left in LTR.

Would really appreciate it if you could add it!
@KaelWD KaelWD added the T: feature A new feature label Aug 5, 2018
@MajesticPotatoe MajesticPotatoe changed the title Spacing should have "start" and "end" directions [Feature Request] Spacing should have "start" and "end" directions Dec 7, 2018
@MajesticPotatoe MajesticPotatoe added the framework Issues and Feature Requests that have needs framework-wide. label Apr 10, 2019
@ibrahimBeladi ibrahimBeladi mentioned this issue Jun 9, 2019
Closed
@ibrahimBeladi
Copy link
Contributor

Will this be implemented and shipped into v2.0?

jacekkarczmarczyk added a commit that referenced this issue Jun 10, 2019
@jacekkarczmarczyk
feat(styles): add rtl/ltr start/end spacing and alignment
733b8c1 
fixes #4660
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Jun 10, 2019
Merged
8 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Jun 10, 2019
jacekkarczmarczyk added a commit that referenced this issue Jun 10, 2019
@jacekkarczmarczyk
feat(styles): add rtl/ltr start/end spacing and alignment
0bb5f4f 
fixes #4660
dsseng added a commit that referenced this issue Jun 11, 2019
@dsseng
Merge branch 'next' into feat/#4660-rtl-spacing
b4b46dd
jacekkarczmarczyk added a commit that referenced this issue Jun 19, 2019
@jacekkarczmarczyk
Merge branch 'next' into feat/#4660-rtl-spacing
2bdc389
jacekkarczmarczyk added a commit that referenced this issue Jun 19, 2019
@jacekkarczmarczyk
feat(styles): add rtl/ltr start/end spacing and alignment (#7448)
3a51619 
* feat(styles): add rtl/ltr start/end spacing and alignment

fixes #4660

* refactor(VDataTable): use *-start instead of *-left

* docs: add start/end descriptions

* docs: add justify description
@jacekkarczmarczyk
Copy link
Member

fixed by #7448

@dsseng dsseng removed the S: has PR The issue has a pending Pull Request label Jun 19, 2019
@johnleider johnleider added this to the v2.0.0 milestone Jun 26, 2019
This was referenced Jul 23, 2019
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
This was referenced Jul 23, 2019
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
This was referenced Aug 13, 2019
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2019
Closed
Merged
Closed
Closed
@renovate renovate bot mentioned this issue Sep 29, 2019
Merged
1 task
@renovate renovate bot mentioned this issue Aug 23, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekkarczmarczyk jacekkarczmarczyk

Labels
framework Issues and Feature Requests that have needs framework-wide. T: feature A new feature
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
7 participants
@tamirvs @johnleider @ibrahimBeladi @jacekkarczmarczyk @KaelWD @dsseng @MajesticPotatoe