Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Calendar is using camelCase for slot names #6704

Closed
nekosaur opened this issue Mar 10, 2019 · 8 comments
Closed

[Bug Report] Calendar is using camelCase for slot names #6704

nekosaur opened this issue Mar 10, 2019 · 8 comments
Assignees
Labels
C: VCalendar VCalendar T: bug Functionality that does not work as intended/expected

Comments

@nekosaur
Copy link
Member

Versions and Environment

Vuetify: 1.5.5
Vue: 2.6.8
Browsers: Chrome 72.0.3626.121
OS: Windows 10

Steps to reproduce

  1. Open codepen
  2. Observe that events are not shown

Expected Behavior

Events are shown

Actual Behavior

Events are not shown

Reproduction Link

https://codepen.io/anon/pen/KEqLaJ?editors=1010

Other comments

We can't use camelCase slot names with the new slot syntax. Will have to be changed to kebab-case.

@nekosaur nekosaur added the T: bug Functionality that does not work as intended/expected label Mar 10, 2019
@ClickerMonkey
Copy link
Contributor

@nekosaur Are kebab-case slots backwards compatible? Do we care?

@MajesticPotatoe
Copy link
Member

@ClickerMonkey camelCase doesnt work with new slot syntax :(

@ClickerMonkey
Copy link
Contributor

I get that, but does kebab-case work with older versions of Vue? I have to admit never seeing it before.

@KaelWD
Copy link
Member

KaelWD commented Mar 19, 2019

No idea if it gets converted to camelCase like props do, but if it doesn't it'd just be this.$slots['kebab-case']

@MajesticPotatoe yeah they do, just not in dom templates (which suck anyway)

@MajesticPotatoe
Copy link
Member

ah 🤦‍♂️ probably best to standardize it across the board anyways.

@Azzeccagarbugli
Copy link

Sorry for the duplicate, I didn't see it at all. Is there any temporary that we should use to fix the current bug? Thank a lot

@nekosaur
Copy link
Member Author

yes, use the old slot syntax

@KaelWD
Copy link
Member

KaelWD commented Jun 21, 2019

Or don't use DOM templates.

https://forum.vuejs.org/t/confused-about-dom-template-and-string-template/1797/2

@nekosaur nekosaur assigned nekosaur and unassigned ClickerMonkey Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCalendar VCalendar T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

5 participants