Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTimePicker): fix disabled props #19964

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

SonTT19
Copy link
Contributor

@SonTT19 SonTT19 commented Jun 7, 2024

Description

Actual Behavior
When using disabled props, only style changed, VTimePicker can still be interacted https://play.vuetifyjs.com/#eNqVUMFOwzAM/RUr4gDS2t6rMmkfwYlyCImHAmkSJU5hmvrvuInKQNqBXSK/5+fn+D2fRYqqO4TQzhlFLwbCKVhJuB8dwDA30X+CtObNPY5CoSOMo4D3nMgcT0ylIBU2Mvrs9CjKUBkjM2ETjPrACHMzeY2W1ZVgA22SfLWo90P3R/tvg6Sit3b1uM2rcnDFcuv0VjqdlAzIzTtOZb205SUcy6lN08Hpp3CRb9srvvqHleMYuR66X/Ey5CtMoCLCr+AjgcajzJbgXP20JHn/sCGAiJSju2CAuqcHl63dbfRSi6UQDIbuZ5NYdkW6Pi/f6kepuA==

Expected Behavior
Can not interact with VTimePicker when using disabled

Markup:

<template>
  <v-row
    align="center"
    justify="space-around"
  >
    <v-time-picker
      v-model="picker"
      disabled
      scrollable
    ></v-time-picker>
    <v-time-picker
      v-model="picker"
      scrollable
    ></v-time-picker>
    <v-time-picker
      v-model="picker"
      :landscape="$vuetify.display.smAndUp"
      disabled
    ></v-time-picker>
  </v-row>
</template>

<script>
  export default {
    data () {
      return {
        picker: null,
      }
    },
  }
</script>

@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VTimePicker VTimePicker labels Jun 11, 2024
@johnleider johnleider added this to the v3.6.x milestone Jun 11, 2024
@johnleider johnleider merged commit 0ba4b78 into master Jun 11, 2024
13 checks passed
@johnleider johnleider deleted the fix/v-time-picker-disabled-props branch June 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTimePicker VTimePicker T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants