Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DateAdapter): update date formats to match document examples #20229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RyanCrompton
Copy link

Description

Fixes #20228

I have tried to match the output to the documentation as closely as possible.

However, fullDateTime/fullDateTime12h/fullDateTime24h should be: Jan 1, 2000 1:00 PM but is currently formatted as Jan 1, 2000, 1:00 PM (note the extra comma after the year.)

Markup:

<template>
  <v-app>
    <v-container>
      <v-text-field v-model="keyboardDateTime" />
      <v-text-field v-model="keyboardDateTime12h" />
      <v-text-field v-model="keyboardDateTime24h" />
    </v-container>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'
  import { useDate } from 'vuetify'
  const keyboardDateTime = ref('')
  const keyboardDateTime12h = ref('')
  const keyboardDateTime24h = ref('')

  const date = useDate()
  keyboardDateTime.value = date.format(new Date(), 'keyboardDateTime')
  keyboardDateTime12h.value = date.format(new Date(), 'keyboardDateTime12h')
  keyboardDateTime24h.value = date.format(new Date(), 'keyboardDateTime24h')
</script>

VPlay Example

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected E: date labels Aug 1, 2024
@KaelWD KaelWD force-pushed the master branch 2 times, most recently from e20cfec to 2766105 Compare August 15, 2024 09:17
@KaelWD KaelWD force-pushed the master branch 3 times, most recently from 4c970f9 to 6a3285f Compare September 3, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: date T: bug Functionality that does not work as intended/expected
Projects
None yet
2 participants