-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing components to $_vuetify_subcomponents #8080
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8080 +/- ##
==========================================
+ Coverage 85.75% 85.77% +0.01%
==========================================
Files 334 334
Lines 9094 9094
Branches 2415 2415
==========================================
+ Hits 7799 7800 +1
+ Misses 1207 1206 -1
Partials 88 88
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 guess ill have to go through and check the apis for these. for another PR though 😄.
I don't think any of the imports you added are supposed to be public. |
@KaelWD row, v-simple-checkbox (which seems to be missing from this), and v-list-item-icon i could see being public. not sure about some of the other ones for tables though, @nekosaur may have to attest to those. I suppose better question would be what changed to cause some of these to stop working? |
v-simple-checkbox should be available. row i'm a bit more ambivalent on, but leaning against no. |
Motivation and Context
fixes #8047
How Has This Been Tested?
jest
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).