Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing components to $_vuetify_subcomponents #8080

Merged
merged 6 commits into from
Jul 28, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #8047

How Has This Been Tested?

jest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.0.x milestone Jul 26, 2019
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #8080 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8080      +/-   ##
==========================================
+ Coverage   85.75%   85.77%   +0.01%     
==========================================
  Files         334      334              
  Lines        9094     9094              
  Branches     2415     2415              
==========================================
+ Hits         7799     7800       +1     
+ Misses       1207     1206       -1     
  Partials       88       88
Impacted Files Coverage Δ
packages/vuetify/src/components/VList/index.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/components/VCheckbox/index.ts 0% <0%> (ø) ⬆️
packages/vuetify/src/components/VSelect/VSelect.ts 94.13% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a755539...583c283. Read the comment docs.

Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 guess ill have to go through and check the apis for these. for another PR though 😄.

@KaelWD
Copy link
Member

KaelWD commented Jul 27, 2019

I don't think any of the imports you added are supposed to be public.

@MajesticPotatoe
Copy link
Member

@KaelWD row, v-simple-checkbox (which seems to be missing from this), and v-list-item-icon i could see being public.
i used v-row and checkbox back in alpha when neko released the tables originally, though those were never really documented.
v-tabs-bar can technically be removed all together as its not used by anything publicly or privately (at least that i could find).
v-list-item-icon is what kinda started all this because apparently a subset of the community used it somehow (even though in 1.5 it didn't seem to be documented).

not sure about some of the other ones for tables though, @nekosaur may have to attest to those.

I suppose better question would be what changed to cause some of these to stop working?

@nekosaur
Copy link
Member

v-simple-checkbox should be available. row i'm a bit more ambivalent on, but leaning against no.

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Jul 28, 2019
@johnleider johnleider merged commit 8aff65a into master Jul 28, 2019
@johnleider johnleider deleted the fix/#8047-missing-components-exports branch July 28, 2019 16:58
@lock lock bot locked as resolved and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Not registered v-list-item-icon
5 participants