Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTabs): slider hides behind the colored tab #8600

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #8596

How Has This Been Tested?

visually

Markup:

<template>
  <v-container>
    <v-tabs background-color="indigo" dark>
      <v-tab class='green'>Option</v-tab>
      <v-tab>Another Selection</v-tab>
      <v-tab class='orange'>Items</v-tab>
      <v-tab>Another Screen</v-tab>
    </v-tabs>
    <v-tabs background-color="indigo" dark>
      <v-tabs-slider color="white" />
      <v-tab class='green'>Option</v-tab>
      <v-tab>Another Selection</v-tab>
      <v-tab class='orange'>Items</v-tab>
      <v-tab>Another Screen</v-tab>
    </v-tabs>
  </v-container>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Aug 17, 2019
@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.0.x milestone Aug 17, 2019
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Aug 17, 2019
@johnleider johnleider merged commit f74b70a into master Aug 22, 2019
@johnleider johnleider deleted the fix/#8596-tabs-slider-z-index branch August 22, 2019 14:20
@lock lock bot locked as resolved and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Tab slider is not visible if we use colour class
4 participants