forked from jaegertracing/jaeger-ui
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix #43 - Search page UI responsiveness sluggish when many spans in r…
…esults (#46) * update eslint-plugin-react, avoid eslintrc warnings * .eslintrc env for browser, jest and jasmine * Fix #43 - Search page responsiveness issues Fix an issue with the search page that shows up when there are many spans (cumulatively) in the search results. Issue at hand is the mapStateToProps function calls .toJS() on some of the immutableJS state values, transforms the resulting values, then passes the transformed values to reselect. The .toJS() invocation prevents the calculations from being memoized by reselect because it always results in new objects or arrays. The change is to wrap the .toJS() call and subsequent transformation in a function, the result of which is cached based on the state value. The caching resolves the issue. Only the last result needs to be cached because these are top-level state values (vs transforming items in an array) and therefore a state value will never be revisited. * Fix yarn lock file, e.g. use npm registry * Fix typo in comment Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
- Loading branch information
Showing
6 changed files
with
194 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright (c) 2017 Uber Technologies, Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| /** | ||
| * Given a transformer function, returns a function that invokes the | ||
| * transformer on the argument and caches the transformation before returning | ||
| * it. If the source value changes, the transformation is recalculated, cached | ||
| * and returned. | ||
| * | ||
| * @param {function} xformer The transformer function, the most recent result | ||
| * of which is cached. | ||
| * @return {function} A wrapper around the transformer function which caches | ||
| * the last transformation, returning the cached value if | ||
| * the source value is the same. | ||
| */ | ||
| export default function getLastXformCacher(xformer) { | ||
| let lastArgs = null; | ||
| let lastXformed = null; | ||
|
|
||
| return function getOrCache(...args) { | ||
| const sameArgs = lastArgs && | ||
| lastArgs.length === args.length && | ||
| lastArgs.every((lastArg, i) => lastArg === args[i]); | ||
| if (sameArgs) { | ||
| return lastXformed; | ||
| } | ||
| lastArgs = args; | ||
| lastXformed = xformer(...args); | ||
| return lastXformed; | ||
| }; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| // Copyright (c) 2017 Uber Technologies, Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| import getLastXformCacher from './get-last-xform-cacher'; | ||
|
|
||
| const xformImpl = value => value + value; | ||
| let xformer; | ||
| let cacher; | ||
|
|
||
| beforeEach(() => { | ||
| xformer = jest.fn(xformImpl); | ||
| cacher = getLastXformCacher(xformer); | ||
| }); | ||
|
|
||
| it('returns a function', () => { | ||
| expect(cacher).toEqual(jasmine.any(Function)); | ||
| }); | ||
|
|
||
| it('handles the first invocation where nothing is cached', () => { | ||
| expect(() => cacher('a')).not.toThrow(); | ||
| }); | ||
|
|
||
| it('the returned function returns the same results as the transformer function', () => { | ||
| expect(cacher('a')).toBe(xformImpl('a')); | ||
| expect(cacher('a')).toBe(xformImpl('a')); | ||
| expect(cacher(1)).toBe(xformImpl(1)); | ||
| expect(cacher('a')).not.toBe(cacher('b')); | ||
| }); | ||
|
|
||
| it('the returned function returns a cached value for subsequent invocation with the same argument', () => { | ||
| expect(xformer.mock.calls.length).toBe(0); | ||
| const value = cacher('a'); | ||
| expect(xformer.mock.calls.length).toBe(1); | ||
| expect(cacher('a')).toBe(value); | ||
| expect(xformer.mock.calls.length).toBe(1); | ||
| }); | ||
|
|
||
| it('the returned function ignores the cached value when invoked with different arguments', () => { | ||
| expect(xformer.mock.calls.length).toBe(0); | ||
| const firstValue = cacher('a'); | ||
| expect(xformer.mock.calls.length).toBe(1); | ||
| expect(cacher('a')).toBe(firstValue); | ||
| expect(xformer.mock.calls.length).toBe(1); | ||
| const secondValue = cacher('b'); | ||
| expect(xformer.mock.calls.length).toBe(2); | ||
| expect(cacher('b')).toBe(secondValue); | ||
| expect(xformer.mock.calls.length).toBe(2); | ||
| }); | ||
|
|
||
| it('the functionality works with multiple arguments', () => { | ||
| const multiXformer = jest.fn((a, b) => [a + a, b + b]); | ||
| const multiCacher = getLastXformCacher(multiXformer); | ||
|
|
||
| expect(multiXformer.mock.calls.length).toBe(0); | ||
| const firstValue = multiCacher('a', 'b'); | ||
|
|
||
| expect(multiXformer.mock.calls.length).toBe(1); | ||
| expect(firstValue).toEqual(['aa', 'bb']); | ||
| expect(multiCacher('a', 'b')).toBe(firstValue); | ||
| expect(multiXformer.mock.calls.length).toBe(1); | ||
|
|
||
| const secondValue = multiCacher('A', 'B'); | ||
| expect(multiXformer.mock.calls.length).toBe(2); | ||
| expect(secondValue).toEqual(['AA', 'BB']); | ||
| expect(multiCacher('A', 'B')).toBe(secondValue); | ||
| expect(multiXformer.mock.calls.length).toBe(2); | ||
|
|
||
| const thirdValue = multiCacher('A', 'B', 'extra-arg'); | ||
| expect(multiXformer.mock.calls.length).toBe(3); | ||
| expect(thirdValue).not.toBe(secondValue); | ||
| expect(thirdValue).toEqual(secondValue); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters