Skip to content

Commit

Permalink
fix: Focus first item in menu dropdowns (#1089)
Browse files Browse the repository at this point in the history
Address #992
  • Loading branch information
Paul-Clue committed May 8, 2024
1 parent 51ddd71 commit 8429aa6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion client/components/TestQueue/AssignTesterDropdown/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ const AssignTesterDropdown = ({
};
return (
<LoadingStatus message={loadingMessage}>
<Dropdown aria-label="Assign testers menu">
<Dropdown focusFirstItemOnShow aria-label="Assign testers menu">
<Dropdown.Toggle
ref={dropdownAssignTesterButtonRef}
aria-label="Assign testers"
Expand Down
7 changes: 5 additions & 2 deletions client/components/TestQueueRow/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ const TestQueueRow = ({

const renderOpenAsDropdown = () => {
return (
<Dropdown className="open-run-as">
<Dropdown className="open-run-as" focusFirstItemOnShow>
<Dropdown.Toggle
id={nextId()}
variant="secondary"
Expand Down Expand Up @@ -265,7 +265,10 @@ const TestQueueRow = ({
if (testPlanRunsWithResults.length) {
return (
<>
<Dropdown aria-label="Delete results menu">
<Dropdown
aria-label="Delete results menu"
focusFirstItemOnShow
>
<Dropdown.Toggle
ref={dropdownDeleteTesterResultsButtonRef}
variant="danger"
Expand Down

0 comments on commit 8429aa6

Please sign in to comment.