Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update combobox examples to use ARIA 1.2 pattern #1244

Closed
jongund opened this issue Nov 5, 2019 · 1 comment · Fixed by #1255
Closed

update combobox examples to use ARIA 1.2 pattern #1244

jongund opened this issue Nov 5, 2019 · 1 comment · Fixed by #1255
Assignees
@zcorpan @jongund @mcking65
Labels
Example Page Related to a page containing an example implementation of a pattern Required for ARIA Spec Resolution needed to permit merging of an ARIA feature into the stable branch of the spec
Milestone
1.2 Third Working...

Comments

@jongund
Copy link
Contributor

jongund commented Nov 5, 2019 •
edited by mcking65
Loading

Develop 4 examples that match the proposed ARIA 1.2 combobox specification by making the following changes to existing examples.
And, eliminate all 1.0 and 1.1 examples.

move the following 3 examples to the /combobox directory and convert to the 1.2 pattern and :
/combobox/aria1.0pattern/combobox-autocomplete-both.html
/combobox/aria1.0pattern/combobox-autocomplete-list.html
/combobox/aria1.0pattern/combobox-autocomplete-none.html
Then remove the aria1.0pattern subdirectory.

Move the following to the combobox directory and convert it to the 1.2 pattern:
/combobox/aria1.1pattern/grid-combo.html
Then remove the /aria1.1pattern/ subdirectory.
@jongund jongund self-assigned this Nov 5, 2019
@mcking65 mcking65 added this to the 1.2 Third Working Draft milestone Nov 6, 2019
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern Required for ARIA Spec Resolution needed to permit merging of an ARIA feature into the stable branch of the spec labels Nov 6, 2019
@mcking65 mcking65 changed the title update combobox grid example to use ARIA 1.2 combobox pattern update combobox examples to use ARIA 1.2 pattern Nov 8, 2019
@mcking65 mcking65 mentioned this issue Nov 8, 2019
Merged
7 tasks
@mcking65
Copy link
Contributor

As part of Pr #1255, The 3 listbox popup examples are ready to review now:

  1. Combobox With Both List and Inline Autocomplete
  2. Combobox With List Autocomplete
  3. Combobox without Autocomplete

Simon is working on the pattern text, and Jon is working on the grid popup example and tests.

mcking65 added a commit that referenced this issue Nov 15, 2019
@mcking65
Combobox Pattern and Examples: Convert to support draft ARIA 1.2 spec…
632bc8a 
…ification (pull #1255)

To resolve #1250 and resolve #1244:
1. Revise the combobox pattern to remove the ARIA 1.0 and ARIA 1.1 guidance and replace with ARIA 1.2 guidance. Keeps a note about ARIA 1.0.
2. In examples, remove ARIA 1.0 and ARIA 1.1 pattern subdirectories and examples.
3. Convert the 3 ARIA 1.0 listbox popup examples into a 1.2 example.
4. Convert the ARIA 1.1 grid popup example into a 1.2 example.
5. Revise regression tests for combobox examples to test the 1.2 versions.
michael-n-cooper pushed a commit that referenced this issue Nov 15, 2019
Generated by TRAVIS-CI 632bc8a
7161ee7 
Combobox Pattern and Examples: Convert to support draft ARIA 1.2 specification (pull #1255)

To resolve #1250 and resolve #1244:
1. Revise the combobox pattern to remove the ARIA 1.0 and ARIA 1.1 guidance and replace with ARIA 1.2 guidance. Keeps a note about ARIA 1.0.
2. In examples, remove ARIA 1.0 and ARIA 1.1 pattern subdirectories and examples.
3. Convert the 3 ARIA 1.0 listbox popup examples into a 1.2 example.
4. Convert the ARIA 1.1 grid popup example into a 1.2 example.
5. Revise regression tests for combobox examples to test the 1.2 versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zcorpan zcorpan

@jongund jongund

@mcking65 mcking65

Labels
Example Page Related to a page containing an example implementation of a pattern Required for ARIA Spec Resolution needed to permit merging of an ARIA feature into the stable branch of the spec
Projects
None yet
Milestone
1.2 Third Working Draft
Development

Successfully merging a pull request may close this issue.

Combobox Pattern and Examples: Convert to support draft ARIA 1.2 specification w3c/aria-practices
3 participants
@zcorpan @jongund @mcking65