Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft switch design pattern #162

Closed
ZoeBijl opened this issue Nov 21, 2016 · 4 comments · Fixed by #1891
Closed

Draft switch design pattern #162

ZoeBijl opened this issue Nov 21, 2016 · 4 comments · Fixed by #1891
Labels
Pattern Page Related to a page documenting a Pattern
Milestone
1.2 Release 1

Comments

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Nov 21, 2016 •
edited by mcking65
Loading

Add guidance on how to code a switch (as opposed to a checkbox). Articles on this:

When to Use a Switch or Checkbox

Preview of branch with work in progress

Switch pattern in switch branch
@mcking65
Copy link
Contributor

Yes, this should have been in the plan for the CR release so adding it to that milestone.

@mcking65 mcking65 added this to the 1.1 PR milestone Nov 22, 2016
@mcking65 mcking65 changed the title Add guidance for switches Draft switch design pattern Jan 19, 2017
@mcking65 mcking65 mentioned this issue Jan 19, 2017
Closed
@mcking65 mcking65 added the Pattern Page Related to a page documenting a Pattern label Jan 25, 2017
@mitchellevan mitchellevan mentioned this issue Mar 19, 2017
Open
mcking65 pushed a commit that referenced this issue Jul 19, 2018
@jongund @mcking65
Add draft of switch design pattern (pull #788)
c6d2ddb 
For issue #162, add draft of design pattern that links to current draft of example.
@mcking65
Copy link
Contributor

Thanks to @jongund, we now have a
Switch pattern in the switch branch.

This is ready for task force review.

@annabbott
Copy link

No issues noted.

ZoeBijl pushed a commit that referenced this issue Feb 5, 2019
@jongund
Add draft of switch design pattern (pull #788)
9c4da45 
For issue #162, add draft of design pattern that links to current draft of example.
@mcking65 mcking65 modified the milestones: 1.1 APG Release 4, 1.2 CR Aug 14, 2019
@mcking65 mcking65 modified the milestones: 1.2 Release 1, 1.2 Release 2 Dec 9, 2019
@mcking65 mcking65 modified the milestones: 1.2 Release 2, 1.2 Release 1 Oct 3, 2021
@mcking65 mcking65 linked a pull request Oct 3, 2021 that will close this issue
Switch Role: Draft Guideance #1891
Merged
@mcking65
Copy link
Contributor

mcking65 commented Oct 3, 2021

Closed by #1891

@mcking65 mcking65 closed this as completed Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pattern Page Related to a page documenting a Pattern
Projects
Switch pattern and example development project
Status: Complete
Milestone
1.2 Release 1
Development

Successfully merging a pull request may close this issue.

Switch Role: Draft Guideance w3c/aria-practices
3 participants
@ZoeBijl @mcking65 @annabbott