Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landmark Practice: Update search landmark guidance to include new HTML search element #2652

Open
scottaohara opened this issue Mar 29, 2023 · 4 comments · May be fixed by #2923
Open

Landmark Practice: Update search landmark guidance to include new HTML search element #2652

scottaohara opened this issue Mar 29, 2023 · 4 comments · May be fixed by #2923
Assignees
@shirsha @curtbellew
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy good first issue Issue with Straightforward resolution; could be good learning experience for new contributors Practice Page Related to a page within the practices section of the APG

Comments

@scottaohara
Copy link
Member

As the search element has landed in the HTML spec, and it maps to an implicit role=search, the role=search section of the landmark regions doc should be updated to replace the text "There is no HTML element that defines a search landmark." with the new reality.

Possibly a note will be needed to indicate that the element is new, and still being implemented into browsers.
@mcking65
Copy link
Contributor

mcking65 commented Apr 2, 2023

Thanks @scottaohara for calling this to the attention of the task force.

It appears to me that the HTML definition of search is more prescriptve ( in a good way) than the ARIA search role. In particular, HTML suggests that the search element is a container for both search and filter functions and that it is not a container for search results. We may want to align APG guidance with such prescriptions.

@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy documentation Practice Page Related to a page within the practices section of the APG good first issue Issue with Straightforward resolution; could be good learning experience for new contributors labels Apr 2, 2023
@mcking65 mcking65 changed the title Landmark explainer update for new search element Landmark Practice: Update search landmark guidance to include new HTML search element Apr 2, 2023
ramiy added a commit to ramiy/aria-practices that referenced this issue Feb 3, 2024
@ramiy
Landmark Regions Practice: Update search landmark guidance to inclu…
5954cf6 
…de new HTML `search` element

The HTML spec now support the `<search>` element. It maps to an implicit `role=search`.

Fix: w3c#2652
@ramiy ramiy linked a pull request Feb 3, 2024 that will close this issue
Open
@rahimabdi
Copy link

rahimabdi commented Feb 3, 2024 •
edited
Loading

As an FYI, I recently observed that the W3C HTML Validator throws a parsing violation when <search> is a descendant of <body>, or even <header> (see MDN <search> article). It's flagging a "Element search is not allowed as a child..." error.

I'm not observing the error when role="search" is used in both of these contexts. Also, not reading any restrictions related to context or content model (HTML search element).

Could this be a validator bug or have I missed something?

@scottaohara
Copy link
Member Author

validator hasn't been updated to properly check this element - validator/validator#1569

@a11ydoer a11ydoer assigned a11ydoer and curtbellew and unassigned a11ydoer Feb 6, 2024
@shirsha shirsha self-assigned this Feb 27, 2024
@shirsha
Copy link

shirsha commented Jun 24, 2024 •
edited
Loading

Guidance is added about new HTML search element. https://deploy-preview-295--aria-practices.netlify.app/aria/apg/practices/landmark-regions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shirsha shirsha

@curtbellew curtbellew

Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy good first issue Issue with Straightforward resolution; could be good learning experience for new contributors Practice Page Related to a page within the practices section of the APG
Projects
Landmark Regions Guidance and Examples Development Project
Status: Next Steps
Milestone
No milestone
6 participants
@scottaohara @mcking65 @shirsha @rahimabdi @a11ydoer @curtbellew