Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA 1.0 Combobox Examples: Escape key does not behave correctly when focus is in the textbox #559

Closed
mcking65 opened this issue Nov 30, 2017 · 5 comments
Assignees
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern

Comments

@mcking65
Copy link
Contributor

mcking65 commented Nov 30, 2017

The combobox with both list and inline autocomplete does not process the escape key correctly when focus is in the textbox.

When focus is in the textbox, if the popup is displayed, Escape should collapse it. Optionally, it can clear the value. It does neither.

Fix Preview Link

Proposed fix can be previewed in the issue559-combo1.0-escape branch.

@mcking65 mcking65 changed the title ARIA 1.0 Combobox Examples: Keyboard Behavior Bugs ARIA 1.0 Combobox Examples: Escape key does not behave correctly when focus is in the textbox Nov 30, 2017
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Nov 30, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 1 milestone Nov 30, 2017
@jongund

This comment has been minimized.

@mcking65
Copy link
Contributor Author

mcking65 commented Jun 24, 2018

Proposed fix can be previewed in the issue559-combo1.0-escape branch.

@mcking65
Copy link
Contributor Author

mcking65 commented Jun 24, 2018

OK, this is confusing. I have not yet merged Jon's fix in pull #734, but I cannot repro the bug on the latest version in master. However, I can repro in the published version on w3.org. Yet, In the history of the js for this example, there have not been any changes since before we published.

Use the following procedure and observe the difference between the published version on w3.org and the current version in master. Note, if using JAWS, press insert+z to disable VC.

  1. Type "c" in the combobox.
  2. Press Delete to delete the "alifornia" that appeared inline.
  3. Press escape.

Behavior on w3.org: Nothing happens when escape is pressed.

Behavior on master: When escape is pressed, the listbox collapses and the "c" in the textbox is cleared.

So, something has fixed master without merging the fix. I don't want to merge #734 if it is not necessary.

There are three files in the JS dir for the combobox 1.0 examples. Their latest commits in master are:

  1. combobox-1.0-list.js: Commit 3048bac on Nov 27, 2017.
  2. listbox.js: commit 3048bac on Nov 27, 2017.
  3. listboxOption.js: Commit 3048bac on Nov 27, 2017.

And, just to be sure ... I checked out the release used to publish the note to make sure that 3048bac is in the history ... and it is:

$ git checkout apg-1.1r1

HEAD is now at 83217c0 really? I have to say WG-NOTE instead of NOTE?

mck@MCK--243 MINGW64 ~/git/APG/main ((apg-1.1r1))
$ git log --oneline  --since="2017-11-26" --before="2017-11-28"
a6dd28d Accordion Design Pattern: Revise Description
13bdfe9 Layout Grid Examples: Close Task Force Review Process
359bbab Grid Design Pattern: Simplify Language
085c74a Grid Design Pattern: Clarify Tab Sequence Statement
47a3d81 Added opening main element
26d16aa Changed aria-valuenow to valuetext in 2 locations
38c06ba Fixed missing closing >
3048bac ARIA 1.0 Combobox Examples: Fix autocomplete behavior (pull #511)
0546d10 ARIA 1.1 Combo with Listbox Popup Example: Close TF Review Process

@mcking65
Copy link
Contributor Author

OK ...as verified by others in yesterday's meeting, master has the problem and the fix is good. I'm not sure what planet my system was on when I could not repro the problem in master on Sunday.

mcking65 added a commit that referenced this issue Jun 27, 2018
Fixes issue #559 by both closing pop-up if open and clearing textbox when escape key is pressed when focus is in the textbox.
@mcking65
Copy link
Contributor Author

Fixed with commit efcd04e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Development

No branches or pull requests

2 participants