-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARIA 1.0 Combobox Examples: Escape key does not behave correctly when focus is in the textbox #559
Comments
This comment has been minimized.
This comment has been minimized.
Proposed fix can be previewed in the issue559-combo1.0-escape branch. |
OK, this is confusing. I have not yet merged Jon's fix in pull #734, but I cannot repro the bug on the latest version in master. However, I can repro in the published version on w3.org. Yet, In the history of the js for this example, there have not been any changes since before we published. Use the following procedure and observe the difference between the published version on w3.org and the current version in master. Note, if using JAWS, press insert+z to disable VC.
Behavior on w3.org: Nothing happens when escape is pressed. Behavior on master: When escape is pressed, the listbox collapses and the "c" in the textbox is cleared. So, something has fixed master without merging the fix. I don't want to merge #734 if it is not necessary. There are three files in the JS dir for the combobox 1.0 examples. Their latest commits in master are:
And, just to be sure ... I checked out the release used to publish the note to make sure that 3048bac is in the history ... and it is:
|
OK ...as verified by others in yesterday's meeting, master has the problem and the fix is good. I'm not sure what planet my system was on when I could not repro the problem in master on Sunday. |
Fixes issue #559 by both closing pop-up if open and clearing textbox when escape key is pressed when focus is in the textbox.
Fixed with commit efcd04e. |
The combobox with both list and inline autocomplete does not process the escape key correctly when focus is in the textbox.
When focus is in the textbox, if the popup is displayed, Escape should collapse it. Optionally, it can clear the value. It does neither.
Fix Preview Link
Proposed fix can be previewed in the issue559-combo1.0-escape branch.
The text was updated successfully, but these errors were encountered: