Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop regression tests for redesigned toolbar #965

Open
mcking65 opened this issue Jan 2, 2019 · 0 comments
Open

Develop regression tests for redesigned toolbar #965

mcking65 opened this issue Jan 2, 2019 · 0 comments
Assignees
@jongund
Labels
regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo

Comments

@mcking65
Copy link
Contributor

mcking65 commented Jan 2, 2019

The redesigned toolbar example
needs regression test for the following data-test-id values:

  • toolbar-right-arrow
  • toolbar-left-arrow
  • toolbar-home
  • toolbar-end
  • toolbar-aria-controls
  • toolbar-button-aria-disabled
  • toolbar-button-aria-label
  • toolbar-button-aria-pressed
  • toolbar-button-enter-or-space
  • toolbar-checkbox-enter-or-space
  • toolbar-link-enter-or-space
  • toolbar-menu-aria-label
  • toolbar-menu-role
  • toolbar-menu-down-arrow
  • toolbar-menu-up-arrow
  • toolbar-menu-enter-or-space
  • toolbar-menu-escape
  • toolbar-menubutton-aria-controls
  • toolbar-menubutton-aria-expanded
  • toolbar-menubutton-aria-haspopup
  • toolbar-menubutton-aria-label
  • toolbar-menubutton-enter-or-space-or-down-or-up
  • toolbar-menuitemradio-aria-checked
  • toolbar-menuitemradio-role
  • toolbar-menuitemradio-tabindex
  • toolbar-radio-aria-checked
  • toolbar-radio-aria-label
  • toolbar-radio-role
  • toolbar-radio-down-arrow
  • toolbar-radio-up-arrow
  • toolbar-radio-enter-or-space
  • toolbar-radiogroup-aria-label
  • toolbar-radiogroup-role
  • toolbar-spinbutton-aria-label
  • toolbar-spinbutton-aria-valuemax
  • toolbar-spinbutton-aria-valuemin
  • toolbar-spinbutton-aria-valuenow
  • toolbar-spinbutton-aria-valuetext
  • toolbar-spinbutton-role
  • toolbar-spinbutton-down-arrow
  • toolbar-spinbutton-up-arrow
  • toolbar-spinbutton-page-down
  • toolbar-spinbutton-page-up
  • toolbar-toggle-enter-or-space
@mcking65 mcking65 added the regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo label Jan 2, 2019
@mcking65 mcking65 added this to the 1.1 APG Release 3 milestone Jan 2, 2019
@mcking65 mcking65 mentioned this issue Jan 2, 2019
Closed
6 tasks
@mcking65 mcking65 mentioned this issue Jan 15, 2019
Merged
mcking65 pushed a commit that referenced this issue Jan 15, 2019
@jongund @mcking65
Toolbar Example: Fix bugs and redesign to add more types of widgets (…
a161bc6 
…#pull 950)

completes work to:

* Resolve keyboard, aria-disabled, and aria-label bugs listed in issue #847.
* Add additional widget types requested in issue #541, including toggle, checkbox, spinner, menu button, radio group, and link.
* The above are all issues discussed in toolbar review issue #539.

Note: missing regression tests are tracked by issue #965.
@zcorpan zcorpan mentioned this issue Feb 25, 2019
Closed
@mcking65 mcking65 modified the milestones: 1.1 APG Release 4, 1.2 CR Aug 13, 2019
@mcking65 mcking65 modified the milestones: 1.2 Release 1, 1.2 Release 2 Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongund jongund

Labels
regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo
Projects
Toolbar Pattern and Examples Development Project
Status: Next Steps
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jongund @mcking65 and others