Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin Button Date Picker Example: Fix February bug #1321

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Feb 4, 2020

This missing reference was uncovered because this test only fails in February -- for which the function getDaysInMonth had some special handling that lead to an error. Fixed it so the function doesn't error!

Preview Link

View the spin button example in the compare branch

@spectranaut spectranaut changed the title Fix AVA error related to missing reference in example and example test file for spinbutton Fix February bug in test file Feb 4, 2020
@mcking65 mcking65 changed the title Fix February bug in test file Spin Button Date Picker Example: Fix February bug Feb 4, 2020
@mcking65
Copy link
Contributor

mcking65 commented Feb 4, 2020

@spectranaut, I'm now able to set the date to february 31, 2020 in the example.

Was using Chrome on Windows.

Is ECMA creating new days for only those of who know about them to use ... I could use a few extra. If this is not a valid secret plot by them, then we should do something about the code. I hope it is a valid plot but fear it is a bug.

@spectranaut
Copy link
Contributor Author

@mcking65 sorry to disappoint, Ecma didn't create any extra days in February, it was only an off by one error on my part! However, today is the EcmaScript meeting, so maybe we should introduce "extra days in February" as a feature request.

I just force pushed and tested the fix locally. Thanks for catching :)

mcking65
mcking65 previously approved these changes Feb 5, 2020
@mcking65
Copy link
Contributor

mcking65 commented Feb 5, 2020

OK, odd, odd, a few minutes ago this compare branch still had the Feb 31 problem. I refreshed my cache and even tried in two other browsers -- still had the problem. So, I tested locally by pulling directly from Valerie's fork. It tested correctly locally. I pushed that to a new branch, tested there and it worked. Now, I come back to this PR and test in its compare branch and the date picker is working fine Oh well.... happy for the fix!!! Time to merge!

@mcking65 mcking65 merged commit 7aa298f into w3c:master Feb 5, 2020
michael-n-cooper pushed a commit that referenced this pull request Feb 5, 2020
Spin Button Date Picker Example: Fix February bug (pull #1321)

This missing reference was uncovered because this test only fails in February -- for which the function getDaysInMonth had some special handling that lead to an error. Fixed it so the function doesn't error!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants