Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combobox date picker example for issue 34 #1413

Merged
merged 59 commits into from
Jul 7, 2020
Merged
Show file tree
Hide file tree
Changes from 57 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
86059fd
Add combobox date picker example for issue 34 pull (#1017)
jongund May 26, 2020
e6ef51f
Editorial revision to intro paragraph and remove link to PR 1017
mcking65 May 26, 2020
bb00bf5
added description, updated regression test and removed information ab…
jongund Jun 9, 2020
3aa892c
fixed code feedback from Cerberooo
jongund Jun 25, 2020
d253dad
fixed spacing
jongund Jun 26, 2020
892df5f
restored datepicker dialog example to master branch
jongund Jun 26, 2020
57b9f32
Add combobox date picker example for issue 34 pull (#1017)
jongund May 26, 2020
0c8a859
Editorial revision to intro paragraph and remove link to PR 1017
mcking65 May 26, 2020
8f73d2f
added description, updated regression test and removed information ab…
jongund Jun 9, 2020
3aad9c7
fixed code feedback from Cerberooo
jongund Jun 25, 2020
b1b7d54
fixed spacing
jongund Jun 26, 2020
c4dd45a
restored datepicker dialog example to master branch
jongund Jun 26, 2020
b1f5139
Add use strict
mcking65 Jul 1, 2020
02f5624
update based om Matt's feednback on 7/2 in PR
jongund Jul 2, 2020
62fa97e
updated documentation
jongund Jul 2, 2020
5a0215c
updated documentation
jongund Jul 2, 2020
bb53697
Merge branch 'master' into issue34-add-combobox-datepicker
mcking65 Jul 4, 2020
0a58243
updated docuemntation on choose date button
jongund Jul 6, 2020
8ecc5e7
removed unused methods
jongund Jul 6, 2020
20e6eaf
Initial revisions to accessibility features section
mcking65 Jul 4, 2020
f234006
Removed information about touchstart event
mcking65 Jul 6, 2020
7f1b224
revise head comment
mcking65 Jul 6, 2020
a1965b9
Fix href of banner link to design pattern
mcking65 Jul 6, 2020
e233d14
Intro: change clicking to activating, remove mention of enter to open
mcking65 Jul 6, 2020
de33a1b
Intro: Change 'grid' link text to mention design pattern, change 'dia…
mcking65 Jul 6, 2020
448195d
Add similar examples list
mcking65 Jul 6, 2020
d21e89d
Add links from other similar examples
mcking65 Jul 6, 2020
5215587
Add link to main doc
mcking65 Jul 6, 2020
f52edeb
Fix link to combobox project
mcking65 Jul 6, 2020
da2a650
Add date picker dialog to similar examples
mcking65 Jul 6, 2020
b1212ae
Remove choose date button kb support section; it is not focusable so …
mcking65 Jul 6, 2020
3c9d1b7
Dialog kb support table: remove mention of grid buttons
mcking65 Jul 6, 2020
7f4e80e
Dialog date buttons: change to
mcking65 Jul 6, 2020
58a37d6
Grid kb support table: Revise descriptions of space and enter to use …
mcking65 Jul 6, 2020
43e5193
Calendar grid kb support table: editorial revisions for grammar, cons…
mcking65 Jul 6, 2020
3e3192d
OK and Cancel KB support: Change to , editorial revisions to descrip…
mcking65 Jul 6, 2020
44ca63c
Change headings to
mcking65 Jul 6, 2020
96a7b2c
add missing period
mcking65 Jul 6, 2020
3912703
Combobox kb support table: editorial revisions for consistency
mcking65 Jul 6, 2020
f1c05ac
Dialog kb support table: editorial revisions for consistency
mcking65 Jul 6, 2020
d581e7b
Fix iincorrect use of q element in similar examples list
mcking65 Jul 6, 2020
d90da81
Replace q tags with quote characters inside of code elements
mcking65 Jul 6, 2020
7e38115
Editorial revisions to combobox roles, states, and props documentation
mcking65 Jul 6, 2020
175f41f
add missing period in e.g.
carmacleod Jul 6, 2020
a3061dd
delete space between dialog and period
carmacleod Jul 6, 2020
811e96e
change a to an
carmacleod Jul 6, 2020
79a6459
Editorial revisions to choose date button states and props documentation
mcking65 Jul 6, 2020
3496e56
Add comma
carmacleod Jul 6, 2020
358402d
Editorial revisions to dialog button role, state, and props documenta…
mcking65 Jul 6, 2020
7c04b8b
change colheader to columnheader
carmacleod Jul 6, 2020
c52e050
Fix white space in states and props section
mcking65 Jul 6, 2020
5652af8
Editorial revisions to grid states and props documentation
mcking65 Jul 6, 2020
bdd4cf4
Resolve conflicts between mcking65 edits and carmacloed edits
mcking65 Jul 7, 2020
c191964
Fix whitespace in grid states and props documentation table
mcking65 Jul 7, 2020
df1dd29
Make space fix suggested by carolyn
mcking65 Jul 7, 2020
eb0b007
Revise accessibility features section (pull #1435)
mcking65 Jul 7, 2020
f187e4a
Change date format string to suggest 4-digit year input
mcking65 Jul 7, 2020
b73e512
removed test for keyboard support for choose date button
jongund Jul 7, 2020
5774347
fixed space key issue on calendar date cell
jongund Jul 7, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aria-practices.html
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@ <h4>Examples</h4>
<li><a href="examples/combobox/combobox-autocomplete-list.html">Editable Combobox with List Autocomplete</a>: An editable combobox that demonstrates the autocomplete behavior known as <q>list with manual selection</q>.</li>
<li><a href="examples/combobox/combobox-autocomplete-none.html">Editable Combobox Without Autocomplete</a>: An editable combobox that demonstrates the behavior associated with <code>aria-autocomplete=none</code>.</li>
<li><a href="examples/combobox/grid-combo.html">Editable Combobox with Grid Popup</a>: An editable combobox that presents suggestions in a grid, enabling users to navigate descriptive information about each suggestion.</li>
<li><a href="examples/combobox/combobox-datepicker.html">Date Picker Combobox</a>: An editable date input combobox that opens a dialog containing a calendar grid and buttons for navigating by month and year.</li>
</ul>
</section>

Expand Down
3 changes: 3 additions & 0 deletions cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
],
"words": [
"activedescendant",
"affordance",
"ahederson",
"alertdialog",
"amet",
Expand Down Expand Up @@ -79,6 +80,7 @@
"Garaventa",
"Geppy",
"gridcell",
"gridcells",
"GUIs",
"Gunderson",
"haspopup",
Expand Down Expand Up @@ -136,6 +138,7 @@
"Nemeth",
"Nihonium",
"nofollow",
"norotate",
"Nurthen",
"NVDA",
"Obel",
Expand Down
1 change: 1 addition & 0 deletions examples/combobox/combobox-autocomplete-both.html
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ <h1>Editable Combobox With Both List and Inline Autocomplete Example</h1>
<li><a href="combobox-autocomplete-list.html">Editable Combobox with List Autocomplete</a>: An editable combobox that demonstrates the autocomplete behavior known as <q>list with manual selection</q>.</li>
<li><a href="combobox-autocomplete-none.html">Editable Combobox Without Autocomplete</a>: An editable combobox that demonstrates the behavior associated with <code>aria-autocomplete=none</code>.</li>
<li><a href="grid-combo.html">Editable Combobox with Grid Popup</a>: An editable combobox that presents suggestions in a grid, enabling users to navigate descriptive information about each suggestion.</li>
<li><a href="combobox-datepicker.html">Date Picker Combobox</a>: An editable date input combobox that opens a dialog containing a calendar grid and buttons for navigating by month and year.</li>
</ul>
<section>
<h2 id="ex_label">Example</h2>
Expand Down
1 change: 1 addition & 0 deletions examples/combobox/combobox-autocomplete-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ <h1>Editable Combobox With List Autocomplete Example</h1>
<li><a href="combobox-autocomplete-both.html">Editable Combobox with Both List and Inline Autocomplete</a>: An editable combobox that demonstrates the autocomplete behavior known as <q>list with inline autocomplete</q>.</li>
<li><a href="combobox-autocomplete-none.html">Editable Combobox Without Autocomplete</a>: An editable combobox that demonstrates the behavior associated with <code>aria-autocomplete=none</code>.</li>
<li><a href="grid-combo.html">Editable Combobox with Grid Popup</a>: An editable combobox that presents suggestions in a grid, enabling users to navigate descriptive information about each suggestion.</li>
<li><a href="combobox-datepicker.html">Date Picker Combobox</a>: An editable date input combobox that opens a dialog containing a calendar grid and buttons for navigating by month and year.</li>
</ul>

<section>
Expand Down
1 change: 1 addition & 0 deletions examples/combobox/combobox-autocomplete-none.html
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ <h1>Editable Combobox without Autocomplete Example</h1>
<li><a href="combobox-autocomplete-both.html">Editable Combobox with Both List and Inline Autocomplete</a>: An editable combobox that demonstrates the autocomplete behavior known as <q>list with inline autocomplete</q>.</li>
<li><a href="combobox-autocomplete-list.html">Editable Combobox with List Autocomplete</a>: An editable combobox that demonstrates the autocomplete behavior known as <q>list with manual selection</q>.</li>
<li><a href="grid-combo.html">Editable Combobox with Grid Popup</a>: An editable combobox that presents suggestions in a grid, enabling users to navigate descriptive information about each suggestion.</li>
<li><a href="combobox-datepicker.html">Date Picker Combobox</a>: An editable date input combobox that opens a dialog containing a calendar grid and buttons for navigating by month and year.</li>
</ul>

<section>
Expand Down
Loading