Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid Combobox Example: Add scroll into view feature #2075

Merged
merged 8 commits into from
Nov 2, 2021
Merged

Grid Combobox Example: Add scroll into view feature #2075

merged 8 commits into from
Nov 2, 2021

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Oct 29, 2021 •
edited
Loading

Changes:

  • Updated code to have option referenced by aria-activedescendant scrolled into view if it was off screen.
  • When list of options is closed the "textbox" will be scrolled into view if it is off screen.
  • Added scroll into view information to Accessibility Documentation.

Preview Link

@jongund jongund changed the title Added scrollto feature to grid combo box example Added scrollto into view feature to grid combo box example Oct 29, 2021
@jongund jongund changed the title Added scrollto into view feature to grid combo box example Added scroll into view feature to grid combo box example Oct 29, 2021
@jongund jongund changed the title Added scroll into view feature to grid combo box example Added scroll into view feature to grid combo box Oct 29, 2021
@zcorpan zcorpan added the Example Page Related to a page containing an example implementation of a pattern label Nov 2, 2021
@zcorpan zcorpan changed the title Added scroll into view feature to grid combo box Grid Combobox Example: Add scroll into view feature Nov 2, 2021
@jesdaigle jesdaigle merged commit 2e58ff9 into main Nov 2, 2021
@jesdaigle jesdaigle deleted the grid-combo-scrollto branch November 2, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcorpan zcorpan zcorpan approved these changes

Assignees
No one assigned
Labels
Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jongund @zcorpan @jesdaigle