Unnest treeview examples for consistency (issue 2418 task) #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcking65
requested changes
Oct 24, 2022
There was a problem hiding this comment.
@alflennik, In treeview-1a.html and treeview-1b, the href of links to the design pattern and treeview-navigation.html need revision.
|
Thank you @mcking65, it seems in my haste to scan for links to treeview-1a and treeview-1b I neglected to fix all the links going in the other direction. I fixed the broken links you referred to, and I went through all the links in the treeview directory to make sure there weren't any others. |
mcking65
approved these changes
Oct 27, 2022
|
Thank you @alflennik! I changed base, fixed conflicts, and fixed one more href that was easy to miss. This is good to go now. I'll merge. |
|
Big thanks Matt for getting it over the finish line! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the file structure of all examples consistent by fixing the inconsistently nested examples in the treeview pattern directory.
See a comment in issue #2418 for more information about this task.
This PR is dependent on other PRs. Once PRs #2499 and #2451 have been merged into #2417, the base of this PR can be changed from
move-examples-nexttomove-examples. I created themove-examples-nextbranch to make writing and reviewing this PR easier.