Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Pages: Change Javascript to JavaScript in h2 elements #2724

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Jun 11, 2023

JavaScript was spelled with a lowercase 's' in the h2 for source files.
This PR corrects the case of the word JavaScript on 57 example pages.
This issue was raised by @coliff in #2382.


WAI Preview Link (Last built on Tue, 13 Jun 2023 18:38:06 GMT).

@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force labels Jun 11, 2023
@mcking65 mcking65 added this to the H1/2023 Content Updates milestone Jun 11, 2023
@mcking65
Copy link
Contributor Author

@charmarkk @a11ydoer @ariellalgilmore @andreancardona @shirsha @jongund

Could one of you take a quick look at this editorial change to make sure I didn't mess anything up? It was a simple search/replace that changed only one line in 57 files. I reviewed the search matches before making the change, but would like a double check before making a change to this many files. It'd be nice to include this in the publication this week.

@a11ydoer a11ydoer self-requested a review June 13, 2023 18:23
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR 2724: Example Pages: Change Javascript to JavaScript in h2 elements by mcking65.

The full IRC log of that discussion <jugglinmike> subtopic: PR 2724: Example Pages: Change Javascript to JavaScript in h2 elements by mcking65
<jugglinmike> github: https://github.com//pull/2724
<jugglinmike> Matt_King: This is my pull request. It is super-simple
<jugglinmike> Jem: I can take a look at that one
<jugglinmike> Matt_King: Thanks!
<jugglinmike> andrea_cardona: And it looks like we have one approval on that already

@mcking65 mcking65 merged commit 3952625 into main Jun 19, 2023
@mcking65 mcking65 deleted the fix-heading-case branch June 19, 2023 07:07
@mcking65
Copy link
Contributor Author

Thank you @andreancardona

@a11ydoer
Copy link
Contributor

looks good to me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants