Port the tests from the B&N contribution #1146
Comments
rdeltour
added a commit
that referenced
this issue
Jul 13, 2020
These tests were initially contributed by B&N for EPUBCheck v4.0. They were very brittle: each test was effectively comparing the entire output details (all messages + EPUB analytics) with expected results. This commit ports the functional tests in the `com.adobe.epubcheck.test` package the new BDD framework. Only the tests for ERROR and WARNING messages are ported. Many USAGE messages originally introduced by the same contribution are not very useful. The tests for these have been discarded. This commit also: - moves the `Messages` localization test to `LocalizedMessagesTest.java` in the messages package. These tests will have to be improved when we refactor the messaging system. - remove the `ApiConstructorsTest` (not very extensive). API testing will be improved when we refactor the public API. - remove the coverage test, which was brittle and not very meaningful. Close #1146.
rdeltour
added a commit
that referenced
this issue
Jul 8, 2022
--------------------- docs: switch to higher quality reference for alternative text Co-authored-by: Jens Oliver Meiert <jens@meiert.com> --------------------- switch to higher quality reference for alternative text fixes #1146 Co-authored-by: Steve Faulkner <faulkner.steve@gmail.com> --------------------- ARIA: Allow aria-required with special input types Add aria-required to input types datetime-local / date / month / time / week Co-authored-by: Daniel <revoltek-daniel@users.noreply.github.com> --------------------- Allow rel attribute on SVG <a> element Fixes validator/validator#1008 Closes validator/validator#1009 Co-authored-by: MattGarrish <mattgarrish@users.noreply.github.com> --------------------- Allow any ARIA role for <svg> element Fixes validator/validator#1096 Fixes validator/validator#981 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow aria.prop.posinset|setsize w/ role=tab Fixes validator/validator#1060 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow “aria-placeholder” where “placeholder” is allowed Also, report error if element with “placeholder” also has “aria-placeholder”. Fixes validator/validator#1098 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow only presentation|none for br[role] Fixes validator/validator#1097 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Update required states for input[type=radio|checkbox] Fixes validator/validator#1109 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Update allowed roles for figure element Fixes validator/validator#1108 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow th[aria-rowspan] & th[aria-colspan] Relates to validator/validator#1107 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow math element to have global ARIA attributes Fixes validator/validator#1114 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Add menu, menubar, and tablist to allowed nav roles Fixes validator/validator#1110 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Align aria-valuemin checking with current spec Fixes validator/validator#1120 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Align aria-valuemax checking with current spec Fixes validator/validator#1119 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow aria-description Fixes validator/validator#1155 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow -1 for aria-setsize Fixes validator/validator#1158 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- update the allowed roles for wbr update allowed roles for `wbr` to match `br` element Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
rdeltour
added a commit
that referenced
this issue
Aug 18, 2022
--------------------- docs: switch to higher quality reference for alternative text Co-authored-by: Jens Oliver Meiert <jens@meiert.com> --------------------- switch to higher quality reference for alternative text fixes #1146 Co-authored-by: Steve Faulkner <faulkner.steve@gmail.com> --------------------- ARIA: Allow aria-required with special input types Add aria-required to input types datetime-local / date / month / time / week Co-authored-by: Daniel <revoltek-daniel@users.noreply.github.com> --------------------- Allow rel attribute on SVG <a> element Fixes validator/validator#1008 Closes validator/validator#1009 Co-authored-by: MattGarrish <mattgarrish@users.noreply.github.com> --------------------- Allow any ARIA role for <svg> element Fixes validator/validator#1096 Fixes validator/validator#981 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow aria.prop.posinset|setsize w/ role=tab Fixes validator/validator#1060 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow “aria-placeholder” where “placeholder” is allowed Also, report error if element with “placeholder” also has “aria-placeholder”. Fixes validator/validator#1098 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow only presentation|none for br[role] Fixes validator/validator#1097 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Update required states for input[type=radio|checkbox] Fixes validator/validator#1109 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Update allowed roles for figure element Fixes validator/validator#1108 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow th[aria-rowspan] & th[aria-colspan] Relates to validator/validator#1107 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow math element to have global ARIA attributes Fixes validator/validator#1114 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Add menu, menubar, and tablist to allowed nav roles Fixes validator/validator#1110 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Align aria-valuemin checking with current spec Fixes validator/validator#1120 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Align aria-valuemax checking with current spec Fixes validator/validator#1119 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow aria-description Fixes validator/validator#1155 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- Allow -1 for aria-setsize Fixes validator/validator#1158 Co-authored-by: Michael[tm] Smith <mike@w3.org> --------------------- update the allowed roles for wbr update allowed roles for `wbr` to match `br` element Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a placeholder issue to keep track of the work in the milestone.
The text was updated successfully, but these errors were encountered: