Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that media overlay playback classes declared #1218

Closed
mattgarrish opened this issue Mar 14, 2021 · 0 comments
Closed

Check that media overlay playback classes declared #1218

mattgarrish opened this issue Mar 14, 2021 · 0 comments
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Milestone
v5.0.0-beta

Comments

@mattgarrish
Copy link
Member

Pretty sure this is impossible to check, but opening for completeness.

I suspect all this could ever be is an info message to check when overlays are present but no classes have been declared, but not sure what value that would have.

w3c/epub-specs#1319
@mattgarrish mattgarrish added the spec: EPUB 3.3 Impacting the support of EPUB 3.3 label Mar 14, 2021
@rdeltour rdeltour added the status: accepted Ready to be further processed label Nov 13, 2021
@rdeltour rdeltour added this to the v5.0.0-beta-1 milestone Nov 13, 2021
@rdeltour rdeltour added status: ready for implem The issue is ready to be implemented status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed status: ready for implem The issue is ready to be implemented labels Jan 23, 2022
rdeltour added a commit that referenced this issue Nov 28, 2022
@rdeltour
feat: better check media overlays styling properties
6a58b8e 
- report schema error RSC-005 when the 'media:active-class' or
  'media:playback-active-class' properties are declared more than once.
- report schema error RSC-005 when the 'media:active-class' or
  'media:playback-active-class' properties define more than once class
  names.
- report new usage CSS-029 when a CSS selector is found referring to
  the widely-used '-epub-media-overlay-active' or '-epub-media-overlay-
  playing' class names but no 'media:active-class' or 'media:playback-
  active-class' properties were declared in the package document.
- report new error CSS-030 when the 'media:active-class' or
  'media:playback-active-class' properties are declared but no CSS is
  found in a content document with media overlays.
- added various test scenarios for the checks described above.

Closs #1218.
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Dec 1, 2022
@rdeltour rdeltour mentioned this issue Dec 2, 2022
Merged
@rdeltour rdeltour closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Projects
None yet
Milestone
v5.0.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish