Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate files ignored #265

Closed
rdeltour opened this issue Oct 15, 2013 · 6 comments
Closed

Duplicate files ignored #265

rdeltour opened this issue Oct 15, 2013 · 6 comments
Labels
type: bug The issue describes a bug

Comments

@rdeltour
Copy link
Member

From jens.tro...@gmail.com on April 28, 2013 09:40:35

PROBLEM: Generating a .zip (epub) file with Python's Zipfile module allows me to store data using the same filename. In my case, I had OEBPS/content.html stored twice in the epub file. METHOD: Using Python, create a epub file and store multiple data under the same filename. RESULT: The first file is checked, duplicates are ignored. EXPECTED: A warning might be nice that there are duplicate filenames in the epub file. PLATFORM: ADDITIONAL INFO: If needed I can attach such a epub file for testing.

Original issue: http://code.google.com/p/epubcheck/issues/detail?id=265

@rdeltour
Copy link
Member Author

From markus.g...@gmail.com on May 21, 2013 05:13:22

Hi Jens,
could you send a sample epub with dupe filenames please? Thanks.

Status: Accepted
Owner: rdeltour@gmail.com
Cc: jens.tro...@gmail.com
Labels: Milestone-3.0.1

@rdeltour
Copy link
Member Author

From markus.g...@gmail.com on May 21, 2013 05:13:49

http://www.idpf.org/epub/30/spec/epub30-ocf.html#sec-container-filenames

Labels: Type-Defect

@rdeltour
Copy link
Member Author

From rdeltour@gmail.com on May 24, 2013 01:37:38

This issue was closed by revision r465 .

Status: Fixed

@rdeltour
Copy link
Member Author

From jens.tro...@gmail.com on July 04, 2013 14:16:11

I completely spaced, and I noticed this has been fixed. Thanks! I've attached a test file anyway; 3.0.1 catches the duplicate chapter.html file.

Attachment: test.epub

@pettarin
Copy link

Testing with the latest code from master, file src/test/resources/30/epub/invalid/issue265.epub passes the validator, while I believe it should fail (I see two ZIP entries with the same name).

Files src/test/resources/30/epub/invalid/issue265b.epub and src/test/resources/30/epub/invalid/issue265c.epub fail the check, as expected.

@tofi86
Copy link
Collaborator

tofi86 commented Dec 23, 2016

@pettarin I also noticed that in Dec. 2015 and opened isse #659 for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue describes a bug
Projects
None yet
Development

No branches or pull requests

3 participants