Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSC-007: also print the missing reference in the error message #720

Closed
tofi86 opened this issue Dec 17, 2016 · 2 comments
Closed

RSC-007: also print the missing reference in the error message #720

tofi86 opened this issue Dec 17, 2016 · 2 comments
Labels
type: duplicate The issue duplicates an existing issue

Comments

@tofi86
Copy link
Collaborator

tofi86 commented Dec 17, 2016

We're and our customers are checking hundreds of EPUBs a month and lot's of people stumble upon the error RSC_007 (Referenced resource could not be found in the EPUB.) as it doesn't provide the referenced resource in the error message.

Yes, the message does provide a location (file, line, col), but normal users are mostly not able to open the EPUB file and locate the error. However, if the missing resource name (only the name, not the path) would be part of the error message, it would be easier for normal users to locate the missing resource in either the EPUB file or the source XML.
@tofi86 tofi86 added the type: improvement The issue suggests an improvement of an existing feature label Dec 17, 2016
@tofi86 tofi86 added this to the Next milestone Dec 17, 2016
@tofi86 tofi86 self-assigned this Dec 17, 2016
@tofi86
Copy link
Collaborator Author

tofi86 commented Dec 18, 2016

duplicate of #475

references #588

@tofi86 tofi86 closed this as completed Dec 18, 2016
@tofi86 tofi86 added type: duplicate The issue duplicates an existing issue and removed type: improvement The issue suggests an improvement of an existing feature labels Dec 18, 2016
@tofi86 tofi86 removed their assignment Dec 18, 2016
@tofi86 tofi86 removed this from the Next milestone Dec 18, 2016
tofi86 added a commit that referenced this issue Dec 18, 2016
@tofi86
add resource in RSC-007 // fixes #475
7d2d61e 
refs #720
rdeltour pushed a commit that referenced this issue Dec 20, 2016
@tofi86 @rdeltour
add resource in RSC-007 // fixes #475
71a76ee 
refs #720
@tofi86
Copy link
Collaborator Author

tofi86 commented Dec 20, 2016

Fixed in PR #722

tofi86 added a commit that referenced this issue Dec 21, 2016
@tofi86
add resource also in RSC-008 // refs #475 #720
5f5ef7b 
for RSC-007 this has already been done with 71a76ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: duplicate The issue duplicates an existing issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tofi86