Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of the epub:switch element is deprecated #895

Closed
mattgarrish opened this issue Nov 12, 2018 · 3 comments
Closed

Use of the epub:switch element is deprecated #895

mattgarrish opened this issue Nov 12, 2018 · 3 comments
Assignees
@rdeltour
Labels
spec: EPUB 3.2 Impacting the support of EPUB 3.2 status: completed Work completed, can be closed
Milestone
4.2.0-alpha-1

Comments

@mattgarrish
Copy link
Member

mattgarrish commented Nov 12, 2018 •
edited
Loading

Detection of the element should generate a warning.

Reference: https://w3c.github.io/publ-epub-revision/epub32/spec/epub-contentdocs.html#sec-xhtml-content-switch

(Correct link now.)
@mattgarrish mattgarrish added the spec: EPUB 3.2 Impacting the support of EPUB 3.2 label Nov 12, 2018
@tofi86
Copy link
Collaborator

tofi86 commented Nov 12, 2018

@mattgarrish this is the wrong link. It links to epub:trigger.

@mattgarrish mattgarrish changed the title Use of the epub:switch elements is deprecated Use of the epub:switch element is deprecated Nov 13, 2018
@mattgarrish mattgarrish added the status: accepted Ready to be further processed label Nov 13, 2018
@rdeltour rdeltour self-assigned this Jan 10, 2019
@rdeltour rdeltour added status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed labels Jan 10, 2019
@rdeltour rdeltour added this to the 4.2.0-alpha-1 milestone Jan 10, 2019
rdeltour added a commit that referenced this issue Jan 14, 2019
@rdeltour
feat: deprecate epub:trigger and epub:switch
c1eac51 
Both are now reported as a WARNING.

Closes #894
Closes #895
@rdeltour rdeltour mentioned this issue Jan 14, 2019
Merged
rdeltour added a commit that referenced this issue Jan 14, 2019
@rdeltour
feat: deprecate epub:trigger and epub:switch
2660058 
Both are now reported as a WARNING.

Closes #894
Closes #895
@rdeltour rdeltour added status: in discussion The issue is being discussed by the development team and removed status: in progress The issue is being implemented by the development team labels Jan 14, 2019
@rdeltour
Copy link
Member

epub:switch is now reported as deprecated with #938.

However, what should we do about the switch property in the OPF? Should it still be checked that the switch property is declared in the Package Document if the author used epub:switch, or should it be totally ignored altogether?

Currently, EPUBCheck keeps on report a missing switch property as an error.

rdeltour added a commit that referenced this issue Jan 14, 2019
@rdeltour
feat: deprecate epub:trigger and epub:switch
08123b2 
Both are now reported as a WARNING.

Closes #894
Closes #895
@rdeltour
Copy link
Member

However, what should we do about the switch property in the OPF?

RESOLUTION: keep the check.

Rationale (from @mattgarrish):

Deprecated only means you shouldn't use, but if someone does we should still be reporting that the feature has been used properly
So long as we emit warning on the features themselves, we can leave the rest of the verification structure intact.

and we do not need to warn about the OPF switch property:

I'd stick with just warning about epub:switch because the use of the property depends on it.

@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in discussion The issue is being discussed by the development team labels Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
spec: EPUB 3.2 Impacting the support of EPUB 3.2 status: completed Work completed, can be closed
Projects
None yet
Milestone
4.2.0-alpha-1
Development

No branches or pull requests
3 participants
@tofi86 @rdeltour @mattgarrish