Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-implement relevant checks from the ctc package in core handlers #1394

Merged
merged 4 commits into from
Dec 5, 2022
Merged

feat: re-implement relevant checks from the ctc package in core handlers #1394

merged 4 commits into from
Dec 5, 2022

Commits on Aug 18, 2022

  1. refactor: move HTM-053 check to OPSHandler 

    `HTM-053` is an INFO-level message that reports links to local files
(absolute `file` URLs).

This check is moved to the core OPSHandler checks, so we can
safely disable the `ctc` package.
    @rdeltour
    rdeltour committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    5263887 View commit details
    Browse the repository at this point in the history

  2. feat: report RSC-018 as RSC-007 instead 

    RSC-018 was introduced in the `ctc` package to check the images
specified in the MathML `altimg` attribute exist in the container.

EPUBCheck already has an error code  for missing resources, namely `RSC-018`.

This  change adds a check for the `altimg` in OPSHandler, and suppresses
`RSC-018`.
    @rdeltour
    rdeltour committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    0550937 View commit details
    Browse the repository at this point in the history

  3. refactor: reimplement HTM-046 and HTM-047 in OPSHandler30 

    `HTM-046` and `HTM-048` check that HTML fixed-layout documents
have viewport metadata.

This change reimplements these checks in `OPSHandler30` so that the
`ctc` package can be disabled.
    @rdeltour
    rdeltour committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    db8d13c View commit details
    Browse the repository at this point in the history

  4. refactor: reimplement CSS-015 in core checkers 

    `CSS-015` reports when a `link` element defining an alternative style sheet
does not have a `title` attribute.  This is required by HTML, see:

  https://html.spec.whatwg.org/multipage/links.html#the-link-is-an-alternative-stylesheet

This check is moved to the core checkers (specifically, in `OPSHandler30`), so
that the `ctc` package can be disabled.
    @rdeltour
    rdeltour committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    122a582 View commit details
    Browse the repository at this point in the history