feat: report 'file' URLs as errors and other URL improvements+tests #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - extracts the URL checking logic from `BaseURLHandler` (SAX handler) to its own independent class `URLChecker` - applies the same URL-checking logic to CSS as was used in XML, using the new `URLChecker` - applies the URL-checking logic to the few places were it wasn't the case already (in XML handlers)
Report `file:` URLs as a new error RSC-030 Fixes #1270
mattgarrish
approved these changes
Dec 2, 2022
Base automatically changed from
feat/overlays-audio-fragments
to
release/v5.0.0
December 6, 2022 14:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: report 'file' URLs as errors
Report
file:URLs as a new error RSC-030Fixes #1270
feat: extend proper URL checking to more places (like CSS)
This commit:
BaseURLHandler(SAX handler)to its own independent class
URLCheckerthe new
URLCheckercase already (in XML handlers)
test: add test for 'mailto' URL
Closes #1265
test: add test for path-absolute URL strings in package document
Closes #1252