Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch's obtain a connection changed slightly #351

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Fetch's obtain a connection changed slightly #351

merged 1 commit into from
Sep 9, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 8, 2021

See whatwg/fetch#1259 for context. This change should be a no-op.


Preview | Diff

See whatwg/fetch#1259 for context. This change should be a no-op.
@annevk
Copy link
Member Author

annevk commented Sep 8, 2021

Review of the linked PR and this PR would be appreciated. I'd like to merge the linked PR soonish, but I'd like you all to be okay with it first.

I recommend not merging this until the linked PR is merged.

Copy link
Contributor

@yutakahirano yutakahirano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

annevk added a commit to whatwg/fetch that referenced this pull request Sep 9, 2021
This is a further incremental step toward making it possible to properly layer WebSocket connections on top of this primitive (see #1243).

WebTransport PR: w3c/webtransport#351.
@annevk
Copy link
Member Author

annevk commented Sep 9, 2021

FWIW, this can land now, https://fetch.spec.whatwg.org/#concept-connection-obtain is updated.

@yutakahirano yutakahirano merged commit 2f78def into w3c:main Sep 9, 2021
github-actions bot added a commit that referenced this pull request Sep 9, 2021
SHA: 2f78def
Reason: push, by @yutakahirano

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@annevk annevk deleted the annevk/fetch-obtain-a-connection branch September 9, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants