Display "No clear winner" above each variant if neither won

wagtail-nest · Dec 16, 2020 · 2132aed · 2132aed
1 parent 6afdf08
commit 2132aed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/wagtail_ab_testing/templates/wagtail_ab_testing/results.html b/wagtail_ab_testing/templates/wagtail_ab_testing/results.html
@@ -45,8 +45,8 @@ <h2>{{ ab_test.name }}</h2>
             </svg>
             <div class="abtest-results">
                 <div class="abtest-results__variant abtest-results__variant--control">
-                    <div class="abtest-results__variant-heading{% if control_is_winner %} abtest-results__variant-heading--winner{% endif %}">
-                        {% if control_is_winner %}{% icon "crown" %} {% trans "Winner!" %}{% endif %}
+                    <div class="abtest-results__variant-heading{% if control_is_winner or unclear_winner %} abtest-results__variant-heading--winner{% endif %}">
+                        {% if control_is_winner %}{% icon "crown" %} {% trans "Winner!" %}{% elif unclear_winner %}{% trans "No clear winner" %}{% endif %}
                     </div>
                     <div class="abtest-results__variant-inner">
                         <h3>{% trans "Control" %} <a href="{% pageurl page %}" target="_blank">{% icon name="link-external" %}</a></h3>
@@ -72,8 +72,8 @@ <h3>{% trans "Control" %} <a href="{% pageurl page %}" target="_blank">{% icon n
                     </div>
                 </div>
                 <div class="abtest-results__variant abtest-results__variant--treatment">
-                    <div class="abtest-results__variant-heading{% if treatment_is_winner %} abtest-results__variant-heading--winner{% endif %}">
-                        {% if treatment_is_winner %}{% icon "crown" %} {% trans "Winner!" %}{% endif %}
+                    <div class="abtest-results__variant-heading{% if treatment_is_winner or unclear_winner %} abtest-results__variant-heading--winner{% endif %}">
+                        {% if treatment_is_winner %}{% icon "crown" %} {% trans "Winner!" %}{% elif unclear_winner %}{% trans "No clear winner" %}{% endif %}
                     </div>
                     <div class="abtest-results__variant-inner">
                         <h3>{% trans "Treatment" %} <a href="{% url 'wagtailadmin_pages:view_draft' page.id %}" target="_blank">{% icon name="link-external" %}</a></h3>

diff --git a/wagtail_ab_testing/views.py b/wagtail_ab_testing/views.py
@@ -311,6 +311,7 @@ def get_progress_and_results_common_context(request, page, ab_test):
         'treatment_conversions_percent': int(treatment_conversions / treatment_participants * 100) if treatment_participants else 0,
         'control_is_winner': ab_test.winning_variant == AbTest.Variant.CONTROL,
         'treatment_is_winner': ab_test.winning_variant == AbTest.Variant.TREATMENT,
+        'unclear_winner': ab_test.status in [AbTest.Status.FINISHED, ab_test.Status.COMPLETED] and ab_test.winning_variant is None,
         'estimated_completion_date': estimated_completion_date,
         'chart_data': json.dumps({
             'x': 'x',