Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: mark revision relation as protected #54

Conversation

disconnect821
Copy link
Contributor

@disconnect821 disconnect821 commented Aug 12, 2023

Fixes #53

This is a counter PR for wagtail/wagtail#10678

can only be merged after the successful merging of #52

  • changes
  • test

@disconnect821 disconnect821 marked this pull request as ready for review August 12, 2023 09:30
@disconnect821
Copy link
Contributor Author

PR is ready for review.
@Stormheg @salty-ivy
thanks a lot for the guidance.

@Stormheg
Copy link
Member

Hi @disconnect821, this is still on my todo list to review. I'll get to it don't worry!

Copy link
Member

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @disconnect821 - this looks perfect to me!

Since this depends on #52, I'll wait for that PR to be merged before merging this one.

@Stormheg Stormheg force-pushed the fix/mark-revision-relation-as-protected branch from b6ddc22 to c680ae2 Compare October 5, 2023 10:28
@Stormheg Stormheg merged commit a866303 into wagtail-nest:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counter part for Avoid purging Revisions #10678
3 participants