Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated css file #66

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jhonatan-lopes
Copy link
Collaborator

The problem

When trying to access the "compare revisions" view in a project with DEBUG=False and whitenoise set up, the view gives a 500 error with the following message:

ValueError: Missing staticfiles manifest entry for 'wagtailadmin/css/layouts/compare-revisions.css'

The cause

This issue is caused by the 'wagtailadmin/css/layouts/compare-revisions.css' stylesheet being moved out of the admin app and into a core.css stylesheet on the 4.0.X branch. See:

The solution

Since core.scss is already loaded by default on the admin panel, the 'compare-revisions.css' stylesheet will also be loaded by default on 4+ versions of Wagtail. Hence, we can simply remove the imports for those stylesheets.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31909a4) 87.84% compared to head (d46e06a) 87.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          15       15           
  Lines         732      732           
  Branches      137      137           
=======================================
  Hits          643      643           
  Misses         54       54           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stormheg Stormheg merged commit 4b76a50 into wagtail-nest:main Dec 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants