Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAL-37 feat: did:web extensions #736

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

WAL-37 feat: did:web extensions #736

wants to merge 50 commits into from

Conversation

cpatsonakis
Copy link
Contributor

@cpatsonakis cpatsonakis commented Sep 6, 2024 •
edited
Loading

Description

Provide a clear and concise description of the changes made in this pull request.

Fixes #735

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cpatsonakis cpatsonakis added the enhancement New feature or request label Sep 6, 2024
@cpatsonakis cpatsonakis self-assigned this Sep 6, 2024
@walt-id walt-id locked and limited conversation to collaborators Sep 6, 2024
@cpatsonakis cpatsonakis changed the title feat: preliminary service and verification method and types feat: did:web extensions Sep 6, 2024
@cpatsonakis
Merge branch 'refs/heads/main' into feat/did-web-extensions
3424121
@cpatsonakis
feat: preliminary models and interface definitions for service and ve…
0e392bc 
…rification method, relationship and respective material
@cpatsonakis
chore: commit forgotten file that causes build to fail
6b8ee2b
@cpatsonakis
feat: preliminary did standard compliant service-related definitions
eddcdc7
@cpatsonakis
test: serialization cases for service endpoint
b22b301
@cpatsonakis
fix: service endpoint url serialization
20bbc1d
@cpatsonakis
fix: service block custom properties serialization and cleanup commen…
9f9aece 
…ted code
@cpatsonakis
test: service block serialization cases
6c977f7
@cpatsonakis
test: did doc service property serialization cases
90c6d55
@cpatsonakis
refactor: rename ServiceType to RegisteredServiceType
c56cd3f
@cpatsonakis
fix: make serviceEndpoint property of ServiceBlock a set of ServiceEn…
d68934b 
…dpoint, remove ServiceEndpointList related code and update test cases accordingly
@cpatsonakis
fix: service is a set of ServiceBlock and remove require not empty check
df9073c
@cpatsonakis
fix: service block type as a set of strings
4c2d821
@cpatsonakis
feat: preliminary verification method and type implementations
a1b4a1b
@cpatsonakis
refactor: verification relationship builders to facilitate js export
76404b9
@cpatsonakis
test: preliminary cases for verification method serialization
39c96d2
@cpatsonakis
test: preliminary cases for verification relationship serialization
fd2b5cf
@cpatsonakis
feat: preliminary definition of did document configuration and associ…
1f905db 
…ated data classes
@cpatsonakis
fix: name class compilation error
ad8fb57
@cpatsonakis
feat: hook DidDocConfig with DidCreateOptions and DidWebCreateOptions…
29612da 
… as optional parameter
@cpatsonakis
refactor: did doc default context list to did utils object
8cc9956
@cpatsonakis cpatsonakis changed the title feat: did:web extensions WAL-37 feat: did:web extensions Sep 16, 2024
cpatsonakis and others added 20 commits September 16, 2024 17:49
@cpatsonakis
test: did doc config preliminary cases for did web registrar
8ab9738
@cpatsonakis
Merge branch 'main' into feat/did-web-extensions
ad83361
@cpatsonakis
refactor: use already created did string
c714a65
@cpatsonakis
feat: add did doc config simplified builders, simplify ServiceConfigu…
0ecf0c0 
…ration type to string and variable name refactoring
@cpatsonakis
fix: parameter conversion in did doc config builder
eb84ae1
@cpatsonakis
test: cases for did doc config builder functions
4fad184
@cpatsonakis
fix: parameter conversion on empty input case
d89fdba
@cpatsonakis
refactor: improve did doc config respective document generation
2d23293
@cpatsonakis
test: root document custom property and service configuration cases f…
1954f6d 
…or did doc config
@cpatsonakis
docs: service endpoint lib documentation and serialization error mess…
1bce223 
…age improvement
@cpatsonakis
docs: service property type and map and refactor ServiceBlock type na…
2184c58 
…me to ServiceMap
@cpatsonakis
docs: verification relationship and type
4cb4c7a
@cpatsonakis
docs: use property instead of param and additional validations in ini…
90ae896 
…t block of ServiceMap
@cpatsonakis
docs: use property instead of param for ServiceEndpoint
3759bb3
@cpatsonakis
docs: verification material type, method and type
379fc08
@cpatsonakis
docs: did web create options
b9c21ca
@cpatsonakis
docs: did doc config types and functions and minor correction on service
7ebbd14
@cpatsonakis
docs: did doc config in did lib README.md
ea0eb7c
@cpatsonakis
Merge branch 'main' into feat/did-web-extensions
4c1624e
@cpatsonakis
docs: add symbol explainer legend below local did operations table
4f3a262
@cpatsonakis cpatsonakis marked this pull request as ready for review September 19, 2024 11:46
@mikeplotean mikeplotean self-requested a review September 20, 2024 08:17
mikeplotean
mikeplotean previously approved these changes Sep 20, 2024
View reviewed changes
...d-libraries/waltid-did/src/commonMain/kotlin/id/walt/did/dids/registrar/dids/DidDocConfig.kt Outdated Show resolved Hide resolved
...braries/waltid-did/src/commonMain/kotlin/id/walt/did/dids/document/models/service/Service.kt Outdated Show resolved Hide resolved
...braries/waltid-did/src/commonMain/kotlin/id/walt/did/dids/document/models/service/Service.kt Outdated Show resolved Hide resolved
...waltid-did/src/commonMain/kotlin/id/walt/did/dids/document/models/service/ServiceEndpoint.kt Outdated Show resolved Hide resolved
...raries/waltid-did/src/commonTest/kotlin/id/walt/did/serialize/service/ServiceEndpointTest.kt Outdated Show resolved Hide resolved
waltid-libraries/waltid-did/src/commonTest/kotlin/id/walt/did/serialize/service/ServiceTest.kt Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikeplotean mikeplotean mikeplotean left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@cpatsonakis cpatsonakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

did:web extensions in DID lib
2 participants
@cpatsonakis @mikeplotean