Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Composer 2 with native Composer Installers #19

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

tiefenb
Copy link
Contributor

@tiefenb tiefenb commented Jun 27, 2021

Support Composer 2 with native Composer Installers instead of hari/pw-module which does not support Composer 2

Support Composer 2 with native Composer Installers instead of hari/pw-module which does not support Composer 2
@wanze
Copy link
Owner

wanze commented Jun 28, 2021

@tiefenb Cool, thanks! :)

Two questions as I don't know the Composer installer myself:

  • Does this also work for new installations with Composer 1, or is Composer 2 a requirement?
  • Is it possible to update the module via composer update if the current version is using hari-pw-module?

Also I just noticed that we should delete the composer.lock file from the repo, because dependencies should not be locked by the module but rather by the consumer's installation.

Cheers 🍻

@tiefenb
Copy link
Contributor Author

tiefenb commented Jun 28, 2021

Hi @wanze !

@daun
Copy link
Contributor

daun commented Jun 28, 2021

composer/installers has been around for a while and works with Composer 1 and 2. At least I've been using it that way. No issues I can recall. The switch from hari to composer/installers has worked well for my modules and should improve compatibility since it supports Composer 1 and 2 while hari supports Composer 1 only.

@wanze wanze merged commit 112b06b into wanze:master Jun 30, 2021
@wanze
Copy link
Owner

wanze commented Jun 30, 2021

Thanks for the nice explanation @tiefenb @daun 👍

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants