Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input change flag #134

Merged
merged 14 commits into from
Sep 4, 2024
Merged

Input change flag #134

merged 14 commits into from
Sep 4, 2024

Conversation

sufikaur
Copy link
Contributor

@sufikaur sufikaur commented Aug 6, 2024

re: #120

Users can edit inputs and access the output tag without re-running. The goal is to add an indication "flag" that the outputs are derived from the inputs run, not the inputs currently in the input tab.

  • added boolean field to indicate inputs changed inputsChanged in FlowsheetConfig
  • inputsChanged is updated when display values are changed in the 'handle' events in ConfigInput
  • Alert component is enabled by flag inputsChanged when true
  • After the running, inputs changed is reset to False in Flowsheet config

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 8, 2024
@sufikaur sufikaur marked this pull request as draft August 8, 2024 20:35
@dangunter
Copy link
Collaborator

@sufikaur could you add a screenshot in a new comment below?

@dangunter
Copy link
Collaborator

@sufikaur what is the status of this now. ready to review?

@MichaelPesce
Copy link
Collaborator

@sufikaur seems to be working well for me. one minor nitpick: when the flag shows up for a parameter sweep, there is no space between the alert and the tabs (see the image attached). maybe just a little padding there would look nice

Screenshot 2024-08-30 at 6 23 43 AM

@sufikaur sufikaur changed the title Draft: Input change flag Input change flag Sep 4, 2024
@MichaelPesce MichaelPesce marked this pull request as ready for review September 4, 2024 20:45
@sufikaur sufikaur merged commit b5c8bda into watertap-org:main Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants