Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output page display #135

Merged
merged 24 commits into from
Oct 3, 2024

Conversation

MichaelPesce
Copy link
Collaborator

  • update output page to display data in a table instead of accordions
  • update input accordions to stack in 2 separate columns

addresses issue #132

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 15, 2024
@MichaelPesce MichaelPesce marked this pull request as ready for review September 5, 2024 15:34
@MichaelPesce
Copy link
Collaborator Author

new output display:
Screenshot 2024-09-05 at 11 34 51 AM

@MichaelPesce
Copy link
Collaborator Author

for comparison, this is what it looked liked prior:
Screenshot 2024-09-05 at 4 33 03 PM

@MichaelPesce
Copy link
Collaborator Author

Screenshot 2024-09-26 at 5 01 15 PM

@avdudchenko
Copy link
Contributor

My one comment, mayne we should swap the value and units? (e.g. var_name, value, units?)

I think this might be easier to read? (note the centering of texts on var (right) and units (left))
image

@MichaelPesce
Copy link
Collaborator Author

@avdudchenko
Screenshot 2024-09-27 at 3 34 57 AM

Copy link
Contributor

@avdudchenko avdudchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs some comments to clarify what new code does. Otherwise, I like the new table look.

@MichaelPesce MichaelPesce merged commit f218ab4 into watertap-org:main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants