Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CO2 be in ADM1 liquid phase too? #1004

Closed
adam-a-a opened this issue Apr 13, 2023 · 3 comments · Fixed by #1012
Closed

Should CO2 be in ADM1 liquid phase too? #1004

adam-a-a opened this issue Apr 13, 2023 · 3 comments · Fixed by #1012
Assignees
Labels
iedo Priority:Normal Normal Priority Issue or PR

Comments

@adam-a-a
Copy link
Contributor

          @adam-a-a I'm wondering where this comment is from? Do you have another component for dissolved CO2? If `S_h2` and `S_ch4` can have liquid phase, I'd expect `S_co2` to have liquid phase as well as it's more dissoluble in the water

Originally posted by @yalinli2 in #1000 (comment)

@adam-a-a
Copy link
Contributor Author

adam-a-a commented Apr 17, 2023

@yalinli2 After further reflection, CO2 dissolved in the liquid phase would be accounted for in S_IC, inorganic carbon in liquid phase. Thus, S_co2 is only explicitly considered in the gas phase in the ADM1 model. However, looking at the literature, S_co2 in liquid phase could be represented as S_IC - S_HCO3-

If that adds up for everyone, we can close this issue.

@yalinli2
Copy link
Member

OK, so you have reactions to account for the gas-liquid equilibrium of CO2? If that's the case then it should be OK, can you modify the comment to reflect this? Thank you!
https://github.com/watertap-org/watertap/blob/main/docs/technical_reference/unit_models/translators/translator_adm1_asm1.rst
https://github.com/watertap-org/watertap/blob/main/docs/technical_reference/unit_models/translators/translator_asm1_adm1.rst

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Apr 20, 2023
@MarcusHolly
Copy link
Contributor

Just for additional clarity, dissolved CO2 is represented by the constraint below in ADM1 (and Modified ADM1). I will update the documentation to make this more clear
image

@MarcusHolly MarcusHolly linked a pull request Apr 21, 2023 that will close this issue
@adam-a-a adam-a-a added the iedo label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iedo Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants