Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Benchmark Simulation Model No. 2 #934

Open
32 of 51 tasks
adam-a-a opened this issue Feb 23, 2023 · 4 comments
Open
32 of 51 tasks

Implementing Benchmark Simulation Model No. 2 #934

adam-a-a opened this issue Feb 23, 2023 · 4 comments
Assignees
Labels
costing enhancement New feature or request iedo master issue model dev team Issues directly related to the model development team Priority:High High Priority Issue or PR property_model

Comments

@adam-a-a
Copy link
Contributor

adam-a-a commented Feb 23, 2023

Description

Our goal is to create a flowsheet for the Benchmark Simulation Model No. 2 (BSM2) which is a standard used in the wastewater treatment industry. BSM2 represents a full wastewater treatment plant (WWTP) that includes the activated sludge process as well as an anaerobic digestor, along with other units.

The ultimate goal is to utilize this detailed, plant-scale model, and prioritized BSM2-related model enhancements that would be required, to facilitate detailed technology comparisons via cost optimization for innovations proposed by teams under the IEDO 2336 effort.

Motivation

This will provide a detailed baseline for wastewater treatment processes and could be used for cost optimization studies.

Running TO-DO:

Questions , points of discussion, and minor issues

  • Address simplification in modified ASM2d where S_IC does not account for carbonate and dissolved CO2 (Serralta 2004)
  • make a baseline activated sludge reactor unit model?
  • Track hydrogen sulfide (H2S) in ADM such that Z_h2s != 0?
  • Delete simple modified ASM2d model?
  • storage tank unit model?

Tasks completed by June 2024 release:

Tasks completed by Mar 2024 release:

Tasks completed by Dec 2023 release:

Tasks completed by Sept 2023 release:

Tasks completed by the June 2023 release:

@lbianchi-lbl
Copy link
Contributor

@adam-a-a @agarciadiego @luohezhiming confirm that it would be good (and doable) to have this done for June.

@adam-a-a
Copy link
Contributor Author

To elaborate, we think it's be doable to have an initial implementation of the full flowsheet functioning with much of the unit documentation in place. However, some of the additional items around model enhancement may spill over past June.

@adam-a-a
Copy link
Contributor Author

Noting this down as I work on #1078 : noticed that the thickener doesn't have its own calculate_scaling_factors nor initialize methods. Instead it would use said methods from the IDAES separator unit, which the thickener class inherits from. Furthermore, testing of scaling is not split into its own test; it is packed in with the testing of initialization of the thickener, and no exploration on badly_scaled_variables or unscaled_constraints is conducted.

@adam-a-a
Copy link
Contributor Author

This relates to #1318 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
costing enhancement New feature or request iedo master issue model dev team Issues directly related to the model development team Priority:High High Priority Issue or PR property_model
Projects
None yet
Development

No branches or pull requests

8 participants