-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial ElectroNP flowsheet #1032
Initial ElectroNP flowsheet #1032
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
==========================================
- Coverage 95.60% 95.56% -0.05%
==========================================
Files 307 308 +1
Lines 29334 29508 +174
==========================================
+ Hits 28045 28199 +154
- Misses 1289 1309 +20 ☔ View full report in Codecov by Sentry. |
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the exception of one small comment, this LGTM.
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on this!
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Initial implementation of electroNP flowsheet with anaerobic digester followed by electroNP unit.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: