Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial ElectroNP flowsheet #1032

Merged
merged 43 commits into from
Jun 13, 2023

Conversation

luohezhiming
Copy link
Contributor

Fixes/Resolves:

(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)

Summary/Motivation:

Initial implementation of electroNP flowsheet with anaerobic digester followed by electroNP unit.

Changes proposed in this PR:

  • Add electroNP flowsheet
  • Add tests
  • Add scaling factor for electroNP_ZO
  • Modify tests

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Attention: Patch coverage is 89.07104% with 20 lines in your changes missing coverage. Please review.

Project coverage is 95.56%. Comparing base (97c9adb) to head (063e52d).
Report is 296 commits behind head on main.

Files with missing lines Patch % Lines
...eets/case_studies/electroNP/electroNP_flowsheet.py 87.87% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   95.60%   95.56%   -0.05%     
==========================================
  Files         307      308       +1     
  Lines       29334    29508     +174     
==========================================
+ Hits        28045    28199     +154     
- Misses       1289     1309      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luohezhiming luohezhiming marked this pull request as ready for review May 18, 2023 17:44
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label May 18, 2023
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of one small comment, this LGTM.

@ksbeattie ksbeattie marked this pull request as draft June 1, 2023 20:31
@luohezhiming luohezhiming marked this pull request as ready for review June 12, 2023 18:01
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this!

@adam-a-a adam-a-a enabled auto-merge (squash) June 13, 2023 01:54
@adam-a-a adam-a-a merged commit a514eb1 into watertap-org:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants