-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add influent/effluent quality metrics for ASM1 #1243
Conversation
self.BOD5 = pyo.Expression( | ||
["raw", "effluent"], | ||
rule=_BOD5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm just not understanding, but is there a reason these two are bundled together as opposed to having a separate expression for each?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only difference between the two is that for treated effluent, the whole expression should be multiplied by one value (0.25), while for another stateblock in the flowsheet (e.g., influent, stream bypassing activated sludge process, etc.), the expression is multiplied by another value (0.65). I could've made them separate but chose to do it this way. Note the BOD5_factor
that I added to the parameter block is also indexed by "raw" or "effluent". (This is the factor that is 0.65 for "raw" and 0.25 for "effluent".)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 356 356
Lines 35766 35793 +27
=======================================
+ Hits 33922 33949 +27
Misses 1844 1844 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'm assuming this PR is done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Once it get merged, we can move forward to do some anlysis on these key metrics.
Fixes/Resolves:
Summary/Motivation:
This PR adds quality metrics to ASM1 which can be used to evaluate WWTP performance and should be useful for optimization cases. Said metrics/properties can now be calculated for any ASM1 stateblock.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: