-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translator block ASM1-ADM1 #962
Conversation
watertap/unit_models/translators/tests/test_translator_asm1_adm1.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from lack of validation data, can you remind me what else is needed to take this out of draft mode? I think it's OK that we don't completely validate results in this PR and note in an issue to be addressed in a subsequent PR. We could also see if we can get data via this repo: https://github.com/wwtmodels/Benchmark-Simulation-Models
Codecov Report
@@ Coverage Diff @@
## main #962 +/- ##
==========================================
+ Coverage 95.47% 95.60% +0.13%
==========================================
Files 285 289 +4
Lines 27244 27437 +193
==========================================
+ Hits 26010 26230 +220
+ Misses 1234 1207 -27
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
watertap/unit_models/translators/tests/test_translator_asm1_adm1.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good- a couple comments, most of them trivial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Summary/Motivation:
Translator block ASM1-ADM1
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: