-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thickener & Dewatering Unit Model Documentation #1017
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1017 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 298 298
Lines 28583 28583
=======================================
Hits 27389 27389
Misses 1194 1194 |
Co-authored-by: Adam Atia <aatia@keylogic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I find that both units are only applicable to ASM1, that means once we move to ASM2d system, we need to consider to upgrate these two units, and it will need more work and documentation updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I find that both units are only applicable to ASM1, that means once we move to ASM2d system, we need to consider to upgrate these two units, and it will need more work and documentation updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I find that both units are only applicable to ASM1, that means once we move to ASM2d system, we need to consider to upgrate these two units, and it will need more work and documentation updates.
Summary/Motivation:
Adds documentation for the thickener and dewatering unit models, both of which are based off the IDAES separator
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: