Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thickener & Dewatering Unit Model Documentation #1017

Merged
merged 8 commits into from
May 18, 2023

Conversation

MarcusHolly
Copy link
Contributor

Summary/Motivation:

Adds documentation for the thickener and dewatering unit models, both of which are based off the IDAES separator

Changes proposed in this PR:

  • Adds unit model documentation

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly added documentation Improvements or additions to documentation Priority:Normal Normal Priority Issue or PR labels Apr 27, 2023
@MarcusHolly MarcusHolly self-assigned this Apr 27, 2023
@MarcusHolly MarcusHolly marked this pull request as ready for review April 27, 2023 19:40
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1017 (94ac7c6) into main (33343a5) will not change coverage.
The diff coverage is n/a.

❗ Current head 94ac7c6 differs from pull request most recent head a19904a. Consider uploading reports for the commit a19904a to get more accurate results

@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files         298      298           
  Lines       28583    28583           
=======================================
  Hits        27389    27389           
  Misses       1194     1194           

Co-authored-by: Adam Atia <aatia@keylogic.com>
@adam-a-a adam-a-a added the iedo label May 4, 2023
@ksbeattie ksbeattie added Priority:High High Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels May 18, 2023
Copy link
Contributor

@luohezhiming luohezhiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I find that both units are only applicable to ASM1, that means once we move to ASM2d system, we need to consider to upgrate these two units, and it will need more work and documentation updates.

Copy link
Contributor

@luohezhiming luohezhiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I find that both units are only applicable to ASM1, that means once we move to ASM2d system, we need to consider to upgrate these two units, and it will need more work and documentation updates.

Copy link
Contributor

@luohezhiming luohezhiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I find that both units are only applicable to ASM1, that means once we move to ASM2d system, we need to consider to upgrate these two units, and it will need more work and documentation updates.

@ksbeattie ksbeattie enabled auto-merge (squash) May 18, 2023 20:57
@ksbeattie ksbeattie merged commit e5df7c5 into watertap-org:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation iedo Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants