-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full wastewater treatment plant with ASM2D for P tracking #1113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of relative
…to consider scaling as needed
51 tasks
…is commit, initialization finally succeeds! But box prob fails to solve right after =(
…epeat_solve to solve function
Merged
We can close the experimental PR thanks to #1276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
Summary/Motivation:
To track phosphorus across the full wastewater treatment plant, a modified version of the ASM2D property/rxn package must replace ASM1, along with a modified form of the ADM1 property/rxn package that ensures compatibility between ASM2D and ADM1.
While PR #1112 is attempting to implement the full flowsheet with inclusion of electronP, building the flowsheet out in a piece-wise manner for debugging and ensuring stability progressively, this PR aims to use the merged full flowsheet that emulates BSM2 (just with different default values) and simply swaps out ASM1 for ASM2D as mentioned earlier, along with new default values given that there are different constituents accounted for in this formulation. Thus, this PR excludes electronP and will troubleshoot stability/convergence issues starting with the complete flowsheet to supplement efforts in #1112 .
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: