Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full wastewater treatment plant with ASM2D for P tracking #1113

Closed
wants to merge 21 commits into from

Conversation

adam-a-a
Copy link
Contributor

Fixes/Resolves:

Summary/Motivation:

To track phosphorus across the full wastewater treatment plant, a modified version of the ASM2D property/rxn package must replace ASM1, along with a modified form of the ADM1 property/rxn package that ensures compatibility between ASM2D and ADM1.

While PR #1112 is attempting to implement the full flowsheet with inclusion of electronP, building the flowsheet out in a piece-wise manner for debugging and ensuring stability progressively, this PR aims to use the merged full flowsheet that emulates BSM2 (just with different default values) and simply swaps out ASM1 for ASM2D as mentioned earlier, along with new default values given that there are different constituents accounted for in this formulation. Thus, this PR excludes electronP and will troubleshoot stability/convergence issues starting with the complete flowsheet to supplement efforts in #1112 .

Changes proposed in this PR:

  • add in modified ASM2d and ADM1 props/rxns and related changes
  • use some default values for concentrations, taken from Flores-Alsina et. al C/MATLAB init files
  • troubleshoot initialization/convergence issues

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@adam-a-a
Copy link
Contributor Author

We can close the experimental PR thanks to #1276

@adam-a-a adam-a-a closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants