Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ADM1/ASM2d Translator #1058

Merged
merged 2 commits into from
Jun 21, 2023
Merged

New ADM1/ASM2d Translator #1058

merged 2 commits into from
Jun 21, 2023

Conversation

MarcusHolly
Copy link
Contributor

Summary/Motivation:

Creates a translator block for the new ASM2d model and renames the translator block for the old, modified ASM2d model to translator_adm1_simple_asm2d

Changes proposed in this PR:

  • Creates translator block and test file for new ASM2d model
  • Renames translator block and test file for old ASM2d model
  • Updates imports in ElectroN-P so that it still uses the old translator block

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly added Priority:Normal Normal Priority Issue or PR iedo labels Jun 14, 2023
@MarcusHolly MarcusHolly self-assigned this Jun 14, 2023
@MarcusHolly MarcusHolly marked this pull request as ready for review June 14, 2023 20:08
luohezhiming
luohezhiming approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@luohezhiming luohezhiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MarcusHolly MarcusHolly added Priority:High High Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels Jun 15, 2023
@MarcusHolly MarcusHolly mentioned this pull request Jun 20, 2023
Merged
adam-a-a
adam-a-a approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adam-a-a adam-a-a enabled auto-merge (squash) June 21, 2023 13:19
@adam-a-a adam-a-a merged commit 1590dc9 into watertap-org:main Jun 21, 2023
@MarcusHolly MarcusHolly mentioned this pull request Jun 21, 2023
Open
51 tasks
@adam-a-a adam-a-a mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-a-a adam-a-a adam-a-a approved these changes

@luohezhiming luohezhiming luohezhiming approved these changes

@agarciadiego agarciadiego Awaiting requested review from agarciadiego

Assignees

@MarcusHolly MarcusHolly

Labels
iedo Priority:High High Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcusHolly @adam-a-a @luohezhiming