Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fsapi to be compatible with Pydantic v2 API #1273

Closed
lbianchi-lbl opened this issue Jan 18, 2024 · 0 comments
Closed

Update fsapi to be compatible with Pydantic v2 API #1273

lbianchi-lbl opened this issue Jan 18, 2024 · 0 comments
Assignees
@dangunter @MichaelPesce @lbianchi-lbl
Labels
fsapi Priority:Normal Normal Priority Issue or PR

Comments

@lbianchi-lbl
Copy link
Contributor

Motivation

  • More and more packages depending on Pydantic have already moved to require pydantic>=2,<3
  • Currently, watertap.ui.fsapi is only compatible with the Pydantic v1 API, and therefore requires pydantic<2
  • This means that WaterTAP is incompatible with (i.e. cannot be installed in the same environment as) any of the aforementioned packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dangunter dangunter

@MichaelPesce MichaelPesce

@lbianchi-lbl lbianchi-lbl

Labels
fsapi Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dangunter @ksbeattie @MichaelPesce @lbianchi-lbl